Rng warnings #1356
Merged
Rng warnings #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 15, 2023
andrewgait
approved these changes
Jun 15, 2023
| @@ -104,6 +108,40 @@ def _prod(iterable): | |||
| return reduce(operator.mul, iterable, 1) | |||
|
|
|||
|
|
|||
| def _all_gen(rd): | |||
There was a problem hiding this comment.
Both this and the following function seem like they should be somewhere more general (utility_calls perhaps?) than in the population vertex. I don't mind them being here for now but perhaps consider moving them somewhere else in the future?
There was a problem hiding this comment.
Yes, could be moved if needed in future; currently they are only ever used here...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that if RNG is used in the wrong place, the user knows about it. This comes as exceptions by default, with an option to turn it into a warning if wanted.
Note that the exception/warning is circumstantial: if the exact parameters mean that things will be generated on machine, but the user has supplied a seeded RNG to places it will be ignored, they are told about it.
All locations in the current code have been fixed in tests and examples. The following have also been changed to match:
SpiNNakerManchester/PyNNExamples#105
SpiNNakerManchester/IntroLab#47
SpiNNakerManchester/microcircuit_model#33
Tested with:
SpiNNakerManchester/IntegrationTests#210