Adding colorbar support to peak activity widget #3646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding colorbar support with option of having variable/fixed range when animating
for more information, see https://pre-commit.ci
|
Hi @abhinavsns Thank you for the PR! Can you add more information in the PR description and a screenshot/screencast of the widget with the change? |
alejoe91
changed the title
zm711
reviewed
Feb 7, 2025
| ): | ||
| rates = self._compute_rates(rec, peaks, duration) | ||
|
|
||
| self.artists = () |
There was a problem hiding this comment.
why did we need to put the artists into the class? It seems like they only exist inside the function or am I misreading?
| self._plot_one_bin( | ||
| rec, probe, peaks, duration, dp.with_channel_ids, dp.with_contact_color, dp.with_interpolated_map | ||
| ) | ||
| if type(dp.fixed_color_range) in [tuple, list]: |
There was a problem hiding this comment.
docstring only says tuple. This is a tiny point though so not sure we need to change.
| rec, probe, peaks, duration, dp.with_channel_ids, dp.with_contact_color, dp.with_interpolated_map | ||
| ) | ||
| if type(dp.fixed_color_range) in [tuple, list]: | ||
| self.vmin, self.vmax = dp.fixed_color_range |
There was a problem hiding this comment.
if you're just putting them into the function why do you need to pull them out and put them in the class?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am following the tutorial located at: https://spikeinterface.readthedocs.io/en/stable/tutorials/widgets/plot_4_peaks_gallery.html
The feature for plotting and animating was already present. This PR adds support for the color bar which is not implemented.
Attached are the screenshot and gifs for the same tutorial when using
with_color_barandfixed_color_rangearguments.