feat: 1.21.5

build.gradle.kts

@@ -31,7 +31,6 @@ loom {
 repositories {
 	mavenCentral()
 	maven("https://maven.spiritstudios.dev/releases/")
-	maven("https://maven.bawnorton.com/releases")
 	maven("https://moehreag.duckdns.org/maven/releases") {
 		content {
 			includeGroup("io.github.axolotlclient.AxolotlClient")
@@ -51,10 +50,6 @@ dependencies {
 	modImplementation(libs.bundles.specter)
 
 	implementation(libs.objc.bridge)
-
-	include("com.github.bawnorton.mixinsquared:mixinsquared-fabric:0.3.3")
-	implementation("com.github.bawnorton.mixinsquared:mixinsquared-fabric:0.3.3")
-	annotationProcessor("com.github.bawnorton.mixinsquared:mixinsquared-fabric:0.3.3")
 }
 
 tasks.processResources {

gradle.properties

@@ -1,9 +1,6 @@
 org.gradle.jvmargs=-Xmx2G
 org.gradle.parallel=true
 
-mod.version = 1.1
+mod.version = 1.1_215-rc1
 mod.group = dev.spiritstudios
 mod.id = snapper
-
-deps.minecraft=1.21.4
-deps.loader=0.16.5

gradle/libs.versions.toml

@@ -2,13 +2,13 @@
 fabric_loom = "1.11-SNAPSHOT"
 minotaur = "2.+"
 
-minecraft = "1.21.4"
-yarn = "1.21.4+build.3"
+minecraft = "1.21.5"
+yarn = "1.21.5+build.1"
 
 fabric_loader = "0.16.14"
-fabric_api = "0.119.3+1.21.4"
+fabric_api = "0.128.1+1.21.5"
 
-specter = "1.1.3"
+specter = "1.1.7"
 objc_bridge = "1.0.0"
 
 [plugins]

src/client/java/dev/spiritstudios/snapper/Snapper.java

@@ -5,8 +5,8 @@
 import dev.spiritstudios.snapper.util.WindowsActions;
 import dev.spiritstudios.snapper.util.config.DirectoryConfigUtil;
 import dev.spiritstudios.snapper.util.uploading.ScreenshotUploading;
-import dev.spiritstudios.specter.api.config.ConfigScreenWidgets;
-import dev.spiritstudios.specter.api.config.ModMenuHelper;
+import dev.spiritstudios.specter.api.config.client.ConfigScreenWidgets;
+import dev.spiritstudios.specter.api.config.client.ModMenuHelper;
 import net.fabricmc.api.ClientModInitializer;
 import net.fabricmc.fabric.api.client.event.lifecycle.v1.ClientLifecycleEvents;
 import net.fabricmc.loader.api.FabricLoader;

src/client/java/dev/spiritstudios/snapper/SnapperKeybindings.java

@@ -4,7 +4,7 @@
 import dev.spiritstudios.snapper.gui.screen.ScreenshotViewerScreen;
 import dev.spiritstudios.snapper.util.ScreenshotActions;
 import dev.spiritstudios.snapper.util.ScreenshotImage;
-import dev.spiritstudios.specter.api.core.util.ClientKeybindEvents;
+import dev.spiritstudios.specter.api.core.client.event.ClientKeybindEvents;
 import net.fabricmc.fabric.api.client.keybinding.v1.KeyBindingHelper;
 import net.minecraft.client.MinecraftClient;
 import net.minecraft.client.option.KeyBinding;
@@ -61,7 +61,7 @@ private static void takePanorama(MinecraftClient client) {
     }
 
     private static void openRecentScreenshot(MinecraftClient client) {
-        List<Path> screenshots = ScreenshotActions.getScreenshots(client);
+        List<Path> screenshots = ScreenshotActions.getScreenshots();
         if (screenshots.isEmpty()) {
             if (client.player != null)
                 client.player.sendMessage(Text.translatable("text.snapper.screenshot_not_exists"), true);

src/client/java/dev/spiritstudios/snapper/gui/overlay/ExternalDialogOverlay.java

@@ -23,14 +23,12 @@ public boolean pausesGame() {
     public void render(DrawContext context, int mouseX, int mouseY, float delta) {
         if (this.client.currentScreen != null) {
             this.client.currentScreen.render(context, mouseX, mouseY, delta);
-            context.draw();
         }
 
         this.client.gameRenderer.renderBlur();
-        this.client.getFramebuffer().beginWrite(false);
 
         context.drawTexture(
-                RenderLayer::getGuiTextured,
+                RenderLayer::getGuiTexturedOverlay,
                 this.client.world == null ? MENU_BACKGROUND_TEXTURE : INWORLD_MENU_BACKGROUND_TEXTURE,
                 0, 0,
                 0, 0,

src/client/java/dev/spiritstudios/snapper/gui/screen/PanoramaViewerScreen.java

@@ -4,6 +4,7 @@
 import dev.spiritstudios.snapper.util.SafeFiles;
 import dev.spiritstudios.snapper.util.ScreenshotImage;
 import dev.spiritstudios.snapper.util.SnapperUtil;
+import net.minecraft.client.MinecraftClient;
 import net.minecraft.client.gui.CubeMapRenderer;
 import net.minecraft.client.gui.DrawContext;
 import net.minecraft.client.gui.RotatingCubeMapRenderer;
@@ -18,6 +19,7 @@
 import java.io.IOException;
 import java.nio.file.Files;
 import java.nio.file.Path;
+import java.util.ArrayList;
 import java.util.List;
 import java.util.Objects;
 import java.util.stream.Stream;
@@ -30,10 +32,31 @@ public class PanoramaViewerScreen extends Screen {
     private final String title;
     private final Screen parent;
 
+    private final List<ScreenshotImage> images = new ArrayList<>();
+
     protected PanoramaViewerScreen(String title, Screen parent) {
         super(Text.translatable("menu.snapper.viewer_menu"));
         this.title = title;
         this.parent = parent;
+        this.client = MinecraftClient.getInstance();
+        assert this.client != null;
+
+        List<Path> panorama = this.getImagePaths();
+        if (panorama == null) {
+            Snapper.LOGGER.error("No panorama found");
+            close();
+            return;
+        }
+
+        for (Path path : panorama) {
+            ScreenshotImage.createPanoramaFace(this.client.getTextureManager(), path)
+                    .ifPresent(screenshotImage -> {
+                        images.add(screenshotImage);
+                        screenshotImage
+                                .load()
+                                .thenAccept(ignored -> screenshotImage.enableFiltering());
+                    });
+        }
     }
 
     @Nullable
@@ -61,6 +84,10 @@ private List<Path> getImagePaths() {
     public void close() {
         Objects.requireNonNull(this.client);
 
+        for (ScreenshotImage image : images) {
+            image.close();
+        }
+
         client.setScreen(this.parent);
     }
 
@@ -83,18 +110,6 @@ protected void init() {
                 ScreenTexts.DONE,
                 button -> this.close()
         ).dimensions(width / 2 + 4, height - 32, 150, 20).build());
-
-        List<Path> panorama = this.getImagePaths();
-        if (panorama == null) {
-            Snapper.LOGGER.error("No panorama found");
-            close();
-            return;
-        }
-
-        for (Path path : panorama) {
-            ScreenshotImage.createPanoramaFace(this.client.getTextureManager(), path)
-                    .ifPresent(ScreenshotImage::enableFiltering);
-        }
     }
 
     @Override

src/client/java/dev/spiritstudios/snapper/gui/screen/ScreenshotScreen.java

@@ -6,12 +6,15 @@
 import dev.spiritstudios.snapper.util.ScreenshotActions;
 import dev.spiritstudios.snapper.util.SnapperUtil;
 import dev.spiritstudios.snapper.util.uploading.ScreenshotUploading;
-import dev.spiritstudios.specter.api.config.RootConfigScreen;
-import net.minecraft.client.MinecraftClient;
+import dev.spiritstudios.specter.api.config.client.RootConfigScreen;
 import net.minecraft.client.gui.DrawContext;
 import net.minecraft.client.gui.screen.Screen;
 import net.minecraft.client.gui.tooltip.Tooltip;
-import net.minecraft.client.gui.widget.*;
+import net.minecraft.client.gui.widget.AxisGridWidget;
+import net.minecraft.client.gui.widget.ButtonWidget;
+import net.minecraft.client.gui.widget.DirectionalLayoutWidget;
+import net.minecraft.client.gui.widget.SimplePositioningWidget;
+import net.minecraft.client.gui.widget.TextIconButtonWidget;
 import net.minecraft.client.util.InputUtil;
 import net.minecraft.screen.ScreenTexts;
 import net.minecraft.text.Text;
@@ -77,7 +80,7 @@ protected void init() {
                 Text.translatable("button.snapper.open"),
                 button -> {
                     if (selectedScreenshot != null)
-                        Util.getOperatingSystem().open(selectedScreenshot.path);
+                        Util.getOperatingSystem().open(selectedScreenshot.icon.getPath());
                 }
         ).width(secondRowButtonWidth).build());
 
@@ -92,23 +95,23 @@ protected void init() {
                 Text.translatable("button.snapper.delete"),
                 button -> {
                     if (selectedScreenshot != null)
-                        ScreenshotActions.deleteScreenshot(selectedScreenshot.path, this);
+                        ScreenshotActions.deleteScreenshot(selectedScreenshot.icon.getPath(), this);
                 }
         ).width(firstRowButtonWidth).build());
 
         this.renameButton = addDrawableChild(ButtonWidget.builder(
                 Text.translatable("button.snapper.rename"),
                 button -> {
                     if (this.selectedScreenshot != null)
-                        client.setScreen(new RenameScreenshotScreen(this.selectedScreenshot.path, this));
+                        client.setScreen(new RenameScreenshotScreen(this.selectedScreenshot.icon.getPath(), this));
                 }
         ).width(firstRowButtonWidth).build());
 
         this.copyButton = addDrawableChild(ButtonWidget.builder(
                 Text.translatable("button.snapper.copy"),
                 button -> {
                     if (selectedScreenshot != null)
-                        Snapper.getPlatformHelper().copyScreenshot(selectedScreenshot.path);
+                        Snapper.getPlatformHelper().copyScreenshot(selectedScreenshot.icon.getPath());
                 }
         ).width(firstRowButtonWidth).build());
 
@@ -118,7 +121,7 @@ protected void init() {
                     if (selectedScreenshot != null)
                         this.client.setScreen(new ScreenshotViewerScreen(
                                 selectedScreenshot.icon,
-                                selectedScreenshot.path,
+                                selectedScreenshot.icon.getPath(),
                                 selectedScreenshot.screenParent
                         ));
                 }
@@ -128,7 +131,7 @@ protected void init() {
             if (selectedScreenshot == null) return;
 
             button.active = false;
-            ScreenshotUploading.upload(selectedScreenshot.path)
+            ScreenshotUploading.upload(selectedScreenshot.icon.getPath())
                     .thenRun(() -> button.active = true);
         }).width(firstRowButtonWidth).build());
 
@@ -241,12 +244,12 @@ public boolean keyPressed(int keyCode, int scanCode, int modifiers) {
         if (selectedScreenshot == null) return false;
 
         if ((modifiers & GLFW.GLFW_MOD_CONTROL) != 0 && keyCode == InputUtil.GLFW_KEY_C) {
-            Snapper.getPlatformHelper().copyScreenshot(selectedScreenshot.path);
+            Snapper.getPlatformHelper().copyScreenshot(selectedScreenshot.icon.getPath());
             return true;
         }
 
         if (keyCode == GLFW.GLFW_KEY_ENTER) {
-            client.setScreen(new ScreenshotViewerScreen(selectedScreenshot.icon, selectedScreenshot.path, this));
+            client.setScreen(new ScreenshotViewerScreen(selectedScreenshot.icon, selectedScreenshot.icon.getPath(), this));
         }
 
         return false;

src/client/java/dev/spiritstudios/snapper/gui/widget/FolderSelectWidget.java

@@ -6,6 +6,7 @@
 import net.minecraft.client.MinecraftClient;
 import net.minecraft.client.gui.DrawContext;
 import net.minecraft.client.gui.ParentElement;
+import net.minecraft.client.gui.screen.Overlay;
 import net.minecraft.client.gui.screen.narration.NarrationMessageBuilder;
 import net.minecraft.client.gui.tooltip.Tooltip;
 import net.minecraft.client.gui.widget.*;
@@ -66,15 +67,11 @@ public FolderSelectWidget(int x, int y, int width, int height, Value<Path> value
                 Text.translatable("config.snapper.snapper.customScreenshotFolder.select"),
                 button -> {
                     ExternalDialogOverlay overlay = new ExternalDialogOverlay();
-                    CompletableFuture<Boolean> assureRender = CompletableFuture.supplyAsync(() -> {
-                        client.setOverlay(overlay);
-                        LOGGER.debug("Opening folder select dialog & overlay"); // THIS SOMEHOW FIXES A BUG; DON'T QUESTION IT
-                        return true;
-                    });
-                    assureRender.thenAccept(e -> {
-                        Optional<Path> folderValue = DirectoryConfigUtil.openFolderSelect(Text.translatable("prompt.snapper.folder_select").getString().replaceAll("[^a-zA-Z0-9 .,]", ""));
-                        valueFromSelectDialog(folderValue.orElse(null));
-                        overlay.close();
+                    client.setOverlay(overlay);
+
+                    DirectoryConfigUtil.openFolderSelect(Text.translatable("prompt.snapper.folder_select").getString().replaceAll("[^a-zA-Z0-9 .,]", "")).thenAccept(path -> {
+                        valueFromSelectDialog(path.orElse(null));
+                        client.submit(overlay::close).join();
                     });
                 },
                 true