This repository was archived by the owner on Dec 24, 2025. It is now read-only.
Fix: multipart api improvement#13
Merged
CallMeEchoCodes merged 2 commits intoSpiritGameStudios:mainfrom Jun 16, 2025
Merged
Conversation
Renamed `PartHolder#parts` to `PartHolder#getEntityParts` Renamed `EntityPart.dims` to `EntityPart.dimensions` and made it protected Made `EntityPart.owner` protected Overrode `getDimensions` in `EntityPart` Slight mixin changes `EntityPartWorld` is now an injected interface
CallMeEchoCodes
suggested changes
Jun 14, 2025
Member
CallMeEchoCodes
left a comment
CallMeEchoCodes
left a comment
There was a problem hiding this comment.
Mostly good, just one mixin with too broad of an inject
specter-entity/src/main/java/dev/spiritstudios/specter/mixin/entity/WorldMixin.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
PartHolder#partstoPartHolder#getEntityPartsEntityPart.dimstoEntityPart.dimensionsand made it protectedEntityPart.ownerprotectedgetDimensionsinEntityPartEntityPartWorldis now an injected interface