-
Notifications
You must be signed in to change notification settings - Fork 1
리뷰모달/후기상한선검사/파일명수정 #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
part3-5
wants to merge
14
commits into
develop
Choose a base branch
from
features/220-modal-review-input-validate
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
리뷰모달/후기상한선검사/파일명수정 #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KimLuka
reviewed
Jan 5, 2025
Member
KimLuka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
기존에 onChange 로 감지하고 유효성 검사하던 것을 usedebounce 로 바꾼 게 맞을까요? 혹시 특별한 이유가 있으셨는지도 궁금합니다~
저는 onChange 가 더 적합하다고 보는데, 이유는 크게 아래 두가지입니다~
- 사용자 경험상 기다리지 않고 입력값에 대해 즉각적인 피드백(검사 결과)를 주는 것이 더 좋다고 생각
- usedebounce 는 과한 네트워크 요청 방지가 필요할 때 더 효과적일 거 같은데, 후기 글자 수 상한선은 api 요청과 무관
그리고 파일명 때문인지 모르겠지만 파일 두 개에서 충돌 일어나서, 확인 부탁드립니다~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🪐 작업 내용
ReviewInput.tsx
useDebounce 훅을 단순화하여 값 자체를 디바운스하도록 변경
콜백 함수 대신 상태 값을 디바운스하는 방식으로 변경
useEffect를 사용하여 디바운스된 값에 대한 처리 구현
useCallback을 사용하여 handleContentChange 최적화
📝 간단하게 설명해주세요
후기 적기 전

200자 이상부터 maxLength prop으로 입력 제한을 처리
