Skip to content

Security Fix: Spending limit usable by removed multisig members #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdeshAtole wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Security Fix: Spending limit usable by removed multisig members #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion programs/squads_multisig_program/src/instructions/spending_limit_use.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,17 @@ impl SpendingLimitUse<'_> {
..
} = self;

// member
// member - must be in BOTH the spending limit's member list AND the multisig's member list.
// SECURITY FIX: Previously only checked spending_limit.members, allowing removed
// multisig members to retain spending limit access.
require!(
spending_limit.members.contains(&member.key()),
MultisigError::Unauthorized
);
require!(
multisig.is_member(member.key()).is_some(),
MultisigError::NotAMember
);

// spending_limit - needs no checking.

Expand Down