Bugfix/remove selectors #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e changes are not being applied
JoshuaKGoldberg
requested changes
Jul 23, 2024
There was a problem hiding this comment.
Ah, it looks like you used npm install instead of pnpm install. You'll want to delete this file.
See https://pnpm.io/ for docs on pnpm.
| -khtml-user-select: none; | ||
| -moz-user-select: none; | ||
| -ms-user-select: none; | ||
| user-select: none; |
There was a problem hiding this comment.
https://caniuse.com/?search=user-select: That SO answer is a good bit outdated. We can use user-select on all major browsers now.
| <slot /> | ||
| <Image alt="" class="squiggle squiggle-right" src={src} /> | ||
| <Image alt="" class="squiggle squiggle-right noselect" src={src} /> |
There was a problem hiding this comment.
Both of these components already have their own squiggle class. You can add the user-select styles to that. There's no need to add a separate noselect class.
.squiggle {
/* (existing styles) */
user-select: none;
}
JoshuaKGoldberg
added
the
status: waiting for author
|
👋 @abhijit360 do you still have energy + time to work on this? |
|
Yes! I will have the PR in this week |
|
(talked offline: may have time later) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Added a noselect class from this
stackoverflowanswer. I tested it locally and it appears to work