Fix MP4 video output in save_video_as_grid_and_mp4
#408
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR addresses a critical issue in the
save_video_as_grid_and_mp4
function when runningvideo_sampling.py
, where video files intended to be saved as MP4 were being mishandled, leading to crashes when writing to MP4 files. The function has been updated to correctly leverageimageio
andffmpeg
for MP4 video creation.Changes:
FFmpeg Integration:
shutil.which("ffmpeg")
. If FFmpeg is not installed, a clear runtime error is raised, prompting the user to install it.imageio-ffmpeg
package is properly installed and functioning in order for the MP4 video encoding to proceed without issues.Video Encoding with Imageio:
save_video_as_grid_and_mp4
by ensuring the use of theffmpeg
format andlibx264
codec for MP4 output.Dependency Update:
requirements.txt
to includeimageio[ffmpeg]==2.26.1
, ensuring that all required video processing dependencies are installed when setting up the environment.How to Test: