feat(webhooks): validate and bound request inputs - #547
Open
Marvelg256 wants to merge 1 commit into
Open
Conversation
- Add rejectInvalidWebhookId helper validating webhook id format (wh_ + 16 lowercase hex chars) on GET/:id, DELETE/:id, PATCH/:id - Fix PATCH handler: remove duplicate rejectUnknownKeys call and reuse validateWebhookEvents instead of duplicating inline event validation - Add WEBHOOK_MAX_URL_LENGTH constant for URL length bound - Add 18 parameterized tests covering malformed webhook IDs on GET, DELETE, and PATCH - Update existing 404 test cases to use valid-format but non-existent IDs (wh_0000000000000000) - Document webhook ID route param validation in docs/validation.md Closes StableRoute-Org#406
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #406
Summary
Related Issue
Closes #
Validation
npm run buildnpm run lintnpm testChecklist
.envfiles, or private credentials.Security Notes
Describe any security assumptions, risks, or mitigations. Write
N/Afor docs-only changes.