feat(config): avoid duplicate pair_reg event on re-registration - #438
Merged
mikewheeleer merged 1 commit intoJul 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
register_pair/register_pairsare documented as idempotent, but previously fired a freshpair_regevent on every call, including a redundant re-assertion of an already-registered pair. This adds a check against the existing registration state sopair_regonly fires on the genuine unregistered→registered transition, satisfying the 'no duplicate emissions' requirement for config-state-change events.Adds two tests: single
register_pairre-call doesn't duplicate the event, and aregister_pairsbatch mixing an already-registered pair with a fresh one only emits for the fresh one.Test output
As noted in #409's PR,
maincurrently failscargo build --testsat HEAD with 103 pre-existing, unrelated errors (duplicate symbol definitions from a prior merge, reproducible viagit stashwith zero local changes). This PR adds zero additional errors — confirmed by diffing the error output before/after this change (identical error set, none referencing the touched functions or new tests).Closes #410