Skip to content

feat(stats): add explicit empty and error states - #577

Merged
mikewheeleer merged 1 commit into
StableRoute-Org:mainfrom
emirykl:grantfox/issue-519-add-explicit-empty-and-error-states-to-the-stats
Jul 27, 2026
Merged

feat(stats): add explicit empty and error states#577
mikewheeleer merged 1 commit into
StableRoute-Org:mainfrom
emirykl:grantfox/issue-519-add-explicit-empty-and-error-states-to-the-stats

Conversation

@emirykl

@emirykl emirykl commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • render a dedicated empty state when no stats are available
  • render an accessible error card with a native retry button
  • announce fetch-state changes through a polite live region
  • keep loading, empty, error, and populated states mutually exclusive
  • cover keyboard retry and successful recovery

Test evidence

  • npm run lint — passed
  • npm test -- --runInBand --no-watchman — 71 suites and 1,224 tests passed
  • focused stats suite — 38 tests passed
  • impacted StatsClient coverage — 100% statements, branches, functions, and lines
  • npm run build — passed
  • Prettier and git diff --check — passed

Fixes #519

Verification

  • PASS: npm run lint
  • PASS: npm test -- --runInBand --no-watchman (71 suites, 1,224 tests)
  • PASS: focused stats tests (38 tests)
  • PASS: StatsClient coverage (100% statements, branches, functions, and lines)
  • PASS: npm run build
  • PASS: Prettier check
  • PASS: git diff --check

Diagnostics

Recovered command failures: /bin/zsh -lc 'npx prettier --check src/app/stats/Client.tsx src/app/stats/page.test.tsx && npx jest src/app/stats/page.test.tsx --runInBand --no-watchman' (1), /bin/zsh -lc './node_modules/.bin/prettier --check src/app/stats/Client.tsx src/app/stats/page.test.tsx && ./node_modules/.bin/jest src/app/stats/page.test.tsx --runInBand --no-watchman' (1)

@mikewheeleer

Copy link
Copy Markdown
Contributor

polished work @emirykl, merging it in 🚀

@mikewheeleer
mikewheeleer merged commit 32484ba into StableRoute-Org:main Jul 27, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add explicit empty and error states to the stats view

2 participants