Skip to content

Conversation

@Potatomonsta
Copy link
Contributor

@Potatomonsta Potatomonsta commented Oct 9, 2025

Description

  • Deleted stac_font_weight.dart parser
  • Removed stac_font_weight export from widgets.dart
  • Deleted stac_scroll_physics.dart utility
  • Removed stac_scroll_physics export from utils.dart

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code refactor
  • Build configuration change
  • Documentation
  • Chore

Summary by CodeRabbit

  • Refactor
    • Removed custom font weight abstraction; font weights now rely on platform defaults.
    • Removed scroll physics presets; scrolling now follows standard platform behavior.
    • Cleaned up related exports to reduce public surface area.
    • May affect existing configurations; review typography and scrolling to ensure desired behavior.

- Deleted stac_font_weight.dart parser
- Removed stac_font_weight export from widgets.dart
- Deleted stac_scroll_physics.dart utility
- Removed stac_scroll_physics export from utils.dart
@coderabbitai
Copy link

coderabbitai bot commented Oct 9, 2025

Walkthrough

Public enums and their mappings were removed: StacFontWeight and StacScrollPhysics. Corresponding barrel exports in widgets.dart and utils.dart were updated to stop re-exporting the removed files. No new code paths or replacements were added.

Changes

Cohort / File(s) Summary of changes
Font weight parser removal
packages/stac/lib/src/parsers/widgets/stac_font_weight/stac_font_weight.dart, packages/stac/lib/src/parsers/widgets/widgets.dart
Deleted StacFontWeight enum and its value getter; removed its export from the widgets barrel.
Scroll physics utility removal
packages/stac/lib/src/utils/stac_scroll_physics.dart, packages/stac/lib/src/utils/utils.dart
Deleted StacScrollPhysics enum and its parse getter; removed its export from the utils barrel.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • divyanshub024

Poem

(_/)
(•_•) I tidy my burrow with hops so light—
Old weights and scrolls bound out of sight.
Thump-thump! The barrels trim and clean,
Less clutter now, a leaner scene.
Carrots compiled; my code runs bright.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly describes the core changes in this pull request by noting the removal of unused files and the cleanup of imports, directly reflecting the deletion of the font weight and scroll physics utilities and their exports. It clearly conveys the main purpose without unnecessary details or ambiguity. As a chore-type commit, it follows conventional commit style and provides sufficient context.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mn/cleanup

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c3fe67 and bec82f4.

📒 Files selected for processing (4)
  • packages/stac/lib/src/parsers/widgets/stac_font_weight/stac_font_weight.dart (0 hunks)
  • packages/stac/lib/src/parsers/widgets/widgets.dart (0 hunks)
  • packages/stac/lib/src/utils/stac_scroll_physics.dart (0 hunks)
  • packages/stac/lib/src/utils/utils.dart (0 hunks)
💤 Files with no reviewable changes (4)
  • packages/stac/lib/src/parsers/widgets/stac_font_weight/stac_font_weight.dart
  • packages/stac/lib/src/utils/stac_scroll_physics.dart
  • packages/stac/lib/src/parsers/widgets/widgets.dart
  • packages/stac/lib/src/utils/utils.dart
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: format
  • GitHub Check: pub_get_check
  • GitHub Check: analyze

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@divyanshub024 divyanshub024 merged commit 3573e29 into dev Oct 9, 2025
6 checks passed
@divyanshub024 divyanshub024 deleted the mn/cleanup branch October 9, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants