-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(button): add vote button variant #1685
Draft
dancormier
wants to merge
5
commits into
develop
Choose a base branch
from
dcormier/vote-btn
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
89b05eb
feat(button): add vote button variant
dancormier 0d16e87
Minor modifications to vote btn in HC mode, focus styles
dancormier a654ffc
Add vote button test images
dancormier 06aef23
Update hover bg color to match prod
dancormier 0d04210
formatting
dancormier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -233,6 +233,92 @@ | |
</div> | ||
</section> | ||
|
||
<section class="stacks-section"> | ||
{% header "h2", "Vote" %} | ||
<p class="stacks-copy">TODO describe</p> | ||
|
||
<div class="stacks-preview"> | ||
{% highlight html %} | ||
<button class="s-btn s-btn__vote" type="button"> | ||
@Svg.ArrowUp | ||
<span class="v-visible-sr">Upvote</span> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would it not be more elegant and shorter to use an |
||
</button> | ||
<button class="s-btn s-btn__vote" type="button"> | ||
@Svg.ArrowDown | ||
<span class="v-visible-sr">Downvote</span> | ||
</button> | ||
<button class="s-btn s-btn__vote is-selected" type="button"> | ||
@Svg.ArrowUp | ||
<span class="v-visible-sr">Upvoted</span> | ||
</button> | ||
<button class="s-btn s-btn__vote is-selected" type="button"> | ||
@Svg.ArrowUp | ||
<span class="v-visible-sr">Downvoted</span> | ||
</button> | ||
|
||
{% endhighlight %} | ||
<div class="stacks-preview--example"> | ||
<div class="overflow-x-auto"> | ||
<table class="wmn5 s-table s-table__bx-simple"> | ||
<thead> | ||
<tr> | ||
<th scope="col">Type</th> | ||
<th scope="col" class="s-table--cell4">Class</th> | ||
<th scope="col" class="ta-center">Default State</th> | ||
<th scope="col" class="ta-center">Selected State</th> | ||
<th scope="col" class="ta-center">Disabled State</th> | ||
</tr> | ||
</thead> | ||
<tbody> | ||
{% for btn in buttons.vote %} | ||
{% assign types = btn.classes %} | ||
{% for class in types %} | ||
<tr> | ||
<th scope="row" class="va-middle">{{ class.title }}</th> | ||
<td class="va-middle"> | ||
<div class="d-flex g4 fw-wrap"> | ||
<code class="flex--item stacks-code">.s-btn</code> | ||
{% if btn.class != nil %} | ||
<code class="flex--item stacks-code">.{{ btn.class }}</code> | ||
{% endif %} | ||
{% if class.class != nil %} | ||
<code class="flex--item stacks-code">.{{ class.class }}</code> | ||
{% endif %} | ||
</div> | ||
</td> | ||
<td class="va-middle ta-center px4"> | ||
<button class="ws-nowrap s-btn {{ btn.class }} {{ class.class }}" type="button"> | ||
{% icon "ArrowUp" %} | ||
<span class="v-visible-sr">Upvote</span> | ||
</button> | ||
</td> | ||
<td class="va-middle ta-center px4"> | ||
<button | ||
class="ws-nowrap s-btn {{ btn.class }} {{ class.class }} is-selected" | ||
type="button"> | ||
{% icon "ArrowUp" %} | ||
<span class="v-visible-sr">Upvoted</span> | ||
</button> | ||
</td> | ||
<td class="va-middle ta-center px4"> | ||
<button | ||
class="ws-nowrap s-btn {{ btn.class }} {{ class.class }}" | ||
type="button" | ||
disabled> | ||
{% icon "ArrowUp" %} | ||
<span class="v-visible-sr">Upvote</span> | ||
</button> | ||
</td> | ||
</tr> | ||
{% endfor %} | ||
{% endfor %} | ||
</tbody> | ||
</table> | ||
</div> | ||
</div> | ||
</div> | ||
</section> | ||
|
||
<section class="stacks-section"> | ||
{% header "h2", "Loading" %} | ||
<p class="stacks-copy">Any button can have a loading state applied by adding the <code class="stacks-code">.is-loading</code> state class.</p> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
screenshots/Chromium/baseline/s-btn-dark-vote-is-selected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
screenshots/Chromium/baseline/s-btn-highcontrast-dark-vote-is-selected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
screenshots/Chromium/baseline/s-btn-highcontrast-dark-vote.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
screenshots/Chromium/baseline/s-btn-highcontrast-light-vote-is-selected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
screenshots/Chromium/baseline/s-btn-highcontrast-light-vote.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
screenshots/Chromium/baseline/s-btn-light-vote-is-selected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
screenshots/Firefox/baseline/s-btn-highcontrast-dark-vote-is-selected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
screenshots/Firefox/baseline/s-btn-highcontrast-dark-vote.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
screenshots/Firefox/baseline/s-btn-highcontrast-light-vote-is-selected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
screenshots/Firefox/baseline/s-btn-highcontrast-light-vote.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
screenshots/Firefox/baseline/s-btn-light-vote-is-selected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
screenshots/Webkit/baseline/s-btn-highcontrast-dark-vote-is-selected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
screenshots/Webkit/baseline/s-btn-highcontrast-light-vote-is-selected.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions
3
screenshots/Webkit/baseline/s-btn-highcontrast-light-vote.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add the appropriate aria attributes to this example since it is used in most places as a toggle: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-pressed