Skip to content

Conversation

dancormier
Copy link
Contributor

@dancormier dancormier commented Oct 20, 2025

SPARK-58


https://deploy-preview-2013--stacks.netlify.app/product/components/award-bling/

TODO

  • Component styles are updated in Stacks Classic
    • Add default style
    • Add filled modifier
    • Add size modifiers (sm, lg, default)
    • Add activity variant
    • Add rep variant
  • Rename to bling
    • Component uses s-bling class
    • Documentation refers to component as Bling
  • Update documentation with new modifier/variant examples
  • Update documentation with copy to describe newly-updated component
  • Update Svelte component
    • Update name to Bling
    • Add filled bool prop
    • Add size string prop
    • Add activity, rep, null (default) to type prop
    • Remove children snippet prop
    • Update markup to match updated markup
    • Update examples to reflect above changes

Follow up

We'll need to follow up on this PR once a few other changes have been made to the system:

  • The activity variant will need to be changed to pink colors once added
  • Visual regression images will need to be regenerated once color palettes are updated

The docs

I have not put too much consideration into the docs. @CGuindon if you have an idea of how these should be updated, let me know and I'll add those changes

Copy link

changeset-bot bot commented Oct 20, 2025

⚠️ No Changeset found

Latest commit: c43503d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Oct 20, 2025

Deploy Preview for stacks-svelte ready!

Name Link
🔨 Latest commit c43503d
🔍 Latest deploy log https://app.netlify.com/projects/stacks-svelte/deploys/68f7f43f0143fd000855f624
😎 Deploy Preview https://deploy-preview-2013--stacks-svelte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Oct 20, 2025

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit c43503d
🔍 Latest deploy log https://app.netlify.com/projects/stacks/deploys/68f7f43fed076d0008f3f94d
😎 Deploy Preview https://deploy-preview-2013--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dancormier dancormier requested a review from CGuindon October 20, 2025 21:47
Copy link
Contributor

@giamir giamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component looks great @dancormier. ❤️🎉

I was lurking around and I wonder if we should add in the acceptance criteria of our stories also the documentation of breaking changes. I know that there is a ticket in the backlog to create a migration doc (v2 to v3). Maybe it would make sense to fill up that document as we go so that our memory is fresh on the breaking changes we made from the point of view of the consumers.

Also, a friendly reminder to add the changesets for this PR. I think this is the first time we’ll have two changesets for two different libraries in the same PR. In any case, npx changeset should guide us through creating these slightly more complex changesets. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants