-
Notifications
You must be signed in to change notification settings - Fork 99
chore(bling): update to SHINE styling #2013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: beta
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for stacks-svelte ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for stacks ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This component looks great @dancormier. ❤️🎉
I was lurking around and I wonder if we should add in the acceptance criteria of our stories also the documentation of breaking changes. I know that there is a ticket in the backlog to create a migration doc (v2 to v3). Maybe it would make sense to fill up that document as we go so that our memory is fresh on the breaking changes we made from the point of view of the consumers.
Also, a friendly reminder to add the changesets for this PR. I think this is the first time we’ll have two changesets for two different libraries in the same PR. In any case, npx changeset
should guide us through creating these slightly more complex changesets. 🙂
SPARK-58
https://deploy-preview-2013--stacks.netlify.app/product/components/award-bling/
TODO
filled
modifiersize
modifiers (sm
,lg
, default)activity
variantrep
variantbling
s-bling
classBling
filled
bool propsize
string propactivity
,rep
, null (default) totype
propchildren
snippet propFollow up
We'll need to follow up on this PR once a few other changes have been made to the system:
activity
variant will need to be changed topink
colors once addedThe docs
I have not put too much consideration into the docs. @CGuindon if you have an idea of how these should be updated, let me know and I'll add those changes