Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appearance:button to s-btn #634

Merged
merged 2 commits into from
Apr 26, 2021
Merged

Add appearance:button to s-btn #634

merged 2 commits into from
Apr 26, 2021

Conversation

benjamin-hodgson
Copy link

@benjamin-hodgson benjamin-hodgson commented Apr 20, 2021

<input type="submit" class="s-btn s-btn__primary"> looks like this on my iphone:

Untitled

Looks like it's coming from the default -webkit-appearance: push-button in the user agent stylesheet.

@aaronshekey
Copy link
Contributor

What version of iOS are you running? I'm not reproducing this one in:

https://codepen.io/aaronshekey/pen/mdRoBQx

@aaronshekey
Copy link
Contributor

Is this overly-specific CSS in Careers that's trolling you?

@benjamin-hodgson
Copy link
Author

No I don't think so. I don't see anything like that in the inspector. Overriding the -webkit-appearance does fix the bug. Plus this is Jobs so most of the CSS comes from SO.

@benjamin-hodgson
Copy link
Author

I'm on iphone 12 pro, ios 14.4.2. Happens in both Chrome and Safari (although that's not surprising since they're basically the same browser)

@aaronshekey
Copy link
Contributor

Does that Codepen have the same issue? ☝️

@benjamin-hodgson
Copy link
Author

Codepen looks correct, but in the inspector I see a rule for [type="submit"] { -webkit-appearance: button; }, which wasn't there on Jobs. Looks like the code is here:

-webkit-appearance: button; /* 2 */
. Why is that rule missing in production?

@aaronshekey
Copy link
Contributor

Why is that rule missing in production?

Oh no, lol. I was just talking about this today. Stacks, for some historical reason, allows for configuration of which reset it uses. I believe that Jobs & Talent ships with reset.css and not normalize.css. By default, Stacks chooses normalize.css, but I'm actively exploring not including either as it's 2021.

Ok, happy to add this in. Thanks for helping me pin down what was causing this.

@aaronshekey aaronshekey merged commit 791dbdd into develop Apr 26, 2021
@aaronshekey aaronshekey deleted the appearance branch April 26, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants