DOCS: Fix CAA_BUILDER parameter types (issuewild type should be string[]) #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @marte26! I see that this is your first PR. That is great! Welcome! Some additional context: the file go generate ./...This means that you (also) need to adjust this change in the source file parameter_types:
label: string?
iodef: string
iodef_critical: boolean?
issue: string[]
- issuewild: string
+ issuewild: string[]Cheers! |
|
I'll take care of |
tlimoncelli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typescript definition file uses the string type for issuewild in CAA_BUILDER, but it should be string[] as noted in the documentation