Bryce spread the word: v1 done #813
Conversation
bryceerobertson
requested review from
melissasamworth,
mruwnik and
LeMurphant
|
I ran |
app/root.css
Outdated
| @@ -253,6 +253,10 @@ h2 { | |||
| padding-bottom: var(--spacing-56) !important; | |||
| } | |||
|
|
|||
| .padding-bottom-64 { | |||
| padding-bottom: var(--spacing-64) !important; | |||
There was a problem hiding this comment.
@melissasamworth are these !importants really needed?
There was a problem hiding this comment.
Dunno, I just copied the format from the previous padding classes made by @melissasamworth
app/root.css
Outdated
| @@ -840,3 +844,30 @@ button { | |||
| } | |||
|
|
|||
| /* end mobile */ | |||
| .video-thumbnail-wrapper { | |||
| position: relative; | |||
There was a problem hiding this comment.
maybe just add a generic relative class that can be applied to arbitrary elements? I'd put these specific classes in a separate css file next to the component that they apply to
There was a problem hiding this comment.
I think I had put this here while troubleshooting the video thumbnail and forgot to delete it afterwards. Removed now.
| title: 'A.I. - Humanity\'s Final Invention?', | ||
| action: 'https://youtu.be/fa8k8IQ1_X0?si=b2l0Ex6KQvt6JyQD', | ||
| image: ( | ||
| <div style={{position: 'relative'}}> |
There was a problem hiding this comment.
it might be worth making a dedicated component for this?
There was a problem hiding this comment.
Made the component but I can't get the play button to behave. That can be a CSS fix for another day
| export default function Grassroots() { | ||
| useEffect(() => { | ||
| document.documentElement.style.scrollBehavior = 'smooth' |
There was a problem hiding this comment.
can this be done with css, rather than js? In general prefer applying css to code, as css generally is a lot more efficient
There was a problem hiding this comment.
That's Myles's work
Some finicky CSS stuff still to do + the "Multiply your impact:" header at the bottom is waiting for Nemo to make it changeable.