Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media carousel from feature request #876 #879

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

zarSou9
Copy link
Contributor

@zarSou9 zarSou9 commented Feb 5, 2025

This adds the ability to create media carousels in articles using this format from google docs. This (I'm pretty sure, but @nemo can you verify) translates in markdown to something like the following:

::: carousel
- [Cat Image Title](https://media.4-paws.org/d/2/5/f/d25ff020556e4b5eae747c55576f3b50886c0b90/cut%20cat%20serhio%2002-1813x1811-720x719.jpg)

- [Cat Gif Title](https://i.giphy.com/SKDiTL793TGiaiV9Kv.webp)

- [Cat Video Title](https://www.youtube.com/watch?v=cytJLvf-eVs)

:::

Which is then parsed, and replaced with a media carousel component which looks like this:

carousel.mov

@LeMurphant
Copy link
Collaborator

LeMurphant commented Feb 5, 2025

There are a lot of extra spaces added, but markdown output looks ok on
https://docs.google.com/document/d/10g6U9SL0CBy__wCBTib7_WhB3S3aaFt7Fx1vVgCzg2I/edit?tab=t.0

::: carousel


- [Cat Image Title](https://media.4-paws.org/d/2/5/f/d25ff020556e4b5eae747c55576f3b50886c0b90/cut%20cat%20serhio%2002-1813x1811-720x719.jpg)

- [Cat Gif Title](https://i.giphy.com/SKDiTL793TGiaiV9Kv.webp)

- [Cat Video Title](https://www.youtube.com/watch?v=cytJLvf-eVs)

:::

@LeMurphant
Copy link
Collaborator

View on site works mostly as expected. I suggest making the left-right arrows a bit thicker.
caroussel

Interface on mobile is not ideal, but I think it's fine. We can improve it if we end up using it extensively.

@Algon-33 do you have the tools to test it in a dev branch?

@LeMurphant
Copy link
Collaborator

I don't know how hard that is, but it would be nice to be able to have captions that appear under the images to clarify what they are.

@zarSou9
Copy link
Contributor Author

zarSou9 commented Feb 5, 2025

I don't know how hard that is, but it would be nice to be able to have captions that appear under the images to clarify what they are.

Agreed, I've just added it

@LeMurphant
Copy link
Collaborator

caroussel2

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants