Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medication sort #41

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Medication sort #41

merged 4 commits into from
Dec 11, 2023

Conversation

AdritRao
Copy link
Collaborator

@AdritRao AdritRao commented Dec 5, 2023

Medication sort

♻️ Current situation & Problem

Currently, the LLM can choose from all resources in the medications category even though many are irrelevant to the user. Specifically, the in-patient medications and MedicationAdministration resources are not relevant.

⚙️ Release Notes

A check for the presence of "inpatient" in the JSON description or MedicationAdministration in the resource title was implemented in FHIRStore+Extensions.swift. Resources which fit into one of these conditions were removed from the sortedMedications.

The relevantResources are still not being updated in the UI after the sort

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #41 (5e1acc3) into main (e74f9ef) will decrease coverage by 0.40%.
The diff coverage is 0.00%.

❗ Current head 5e1acc3 differs from pull request most recent head e8506db. Consider uploading reports for the commit e8506db to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
- Coverage   41.47%   41.07%   -0.40%     
==========================================
  Files          31       31              
  Lines        1225     1237      +12     
==========================================
  Hits          508      508              
- Misses        717      729      +12     
Files Coverage Δ
...HIR/FHIR Interpretation/FHIRStore+Extensions.swift 35.09% <0.00%> (-9.35%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e74f9ef...e8506db. Read the comment docs.

@PSchmiedmayer PSchmiedmayer marked this pull request as ready for review December 11, 2023 08:08
@PSchmiedmayer PSchmiedmayer merged commit 98f1a87 into main Dec 11, 2023
3 checks passed
@PSchmiedmayer PSchmiedmayer deleted the medication_sort branch December 11, 2023 08:18
@PSchmiedmayer PSchmiedmayer self-assigned this Dec 11, 2023
@PSchmiedmayer PSchmiedmayer added the enhancement New feature or request label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants