Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix angular velocity calculation for proprioception dictionary for TwoWheelRobot #257

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sujaygarlanka
Copy link

@cgokmen
Copy link
Collaborator

cgokmen commented Jan 14, 2023

Hi @roberto-martinmartin , could you please review this PR and the relevant math in the issue the author linked? I'll merge it into the develop branch later.

@sujaygarlanka
Copy link
Author

sujaygarlanka commented Jan 14, 2023

Hello @cgokmen, I use iGibson in a lab I am currently working in. I am interested in learning more about the library and contributing to open source. Do you guys have a list of bugs/features you are looking to fix/implement, especially for newcomers to iGibson? I know some open source libraries like Tensorflow do this by tagging issues as shown here.

@cgokmen
Copy link
Collaborator

cgokmen commented Jan 14, 2023

Hello @cgokmen, I use iGibson in a lab I am currently working in. I am interested in learning more about the library and contributing to open source. Do you guys have a list of bugs/features you are looking to fix/implement, especially for newcomers to iGibson? I know some open source libraries like Tensorflow do this by tagging issues as shown here.

Hi Sujay,

Thanks for your contribution and for your interest! So up until now, iGibson, despite being an open-source project, was developed in a private repository and this public repository was used mostly for releases + issues. However, we are in the process of migrating it fully to this public repository, at which time all users will be able to see development, open PRs, view our roadmap etc. at which time it should become much easier for you to contribute. I'll be sure to expedite this process, and will keep you posted.

Thanks,
Cem

@sujaygarlanka
Copy link
Author

Hello @cgokmen, I use iGibson in a lab I am currently working in. I am interested in learning more about the library and contributing to open source. Do you guys have a list of bugs/features you are looking to fix/implement, especially for newcomers to iGibson? I know some open source libraries like Tensorflow do this by tagging issues as shown here.

Hi Sujay,

Thanks for your contribution and for your interest! So up until now, iGibson, despite being an open-source project, was developed in a private repository and this public repository was used mostly for releases + issues. However, we are in the process of migrating it fully to this public repository, at which time all users will be able to see development, open PRs, view our roadmap etc. at which time it should become much easier for you to contribute. I'll be sure to expedite this process, and will keep you posted.

Thanks, Cem

Sounds good. Thanks, Cem!

@sujaygarlanka sujaygarlanka requested review from ChengshuLi and removed request for roberto-martinmartin January 15, 2023 16:31
@sujaygarlanka
Copy link
Author

Hello @cgokmen,

I am looking to fix the issues #248 and #249 that I reported a while back so our lab code doesn't diverge from the master branch. Since the iGibson repo is not open source yet and I am not sure if these are being worked on in the private repo, do you recommend holding off until it is open source?

Thanks,
Sujay

@mjlbach
Copy link
Collaborator

mjlbach commented Feb 1, 2023

We've archived the internal repo at this point, so all development is now happening on this (public) repo going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants