-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from apache:master #17
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Danny McCormick <[email protected]>
Reviewer's Guide by SourceryThis pull request fixes a typo in the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
🚨 gitStream Monthly Automation Limit Reached 🚨 Your organization has exceeded the number of pull requests allowed for automation with gitStream. To continue automating your PR workflows and unlock additional features, please contact LinearB. |
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…ces. (#33901) add a utility class to enable sharing across all deserialized instances of a DoFn and use it in UnboundedSourceAsSdfWrapperFn to cache Readers across dofn instances
* Add threshold and aggregation functions. Also include the following changes: * change prediction to predictions (iterable) in AnomalyResult. * fix some tests that contaminate _KNONW_SPECIFIABLE * Fix lints. * Get rid of _run_init. The init will be called just-in-time. * Add logic to handle missing and error labels/scores. Also includes the following adjustments per reviewer's feedback - Rename include_history to include_source_predictions. - Get rid of the unnecessary cast * Fix lints.
Bumps [github.com/tetratelabs/wazero](https://github.com/tetratelabs/wazero) from 1.8.2 to 1.9.0. - [Release notes](https://github.com/tetratelabs/wazero/releases) - [Commits](tetratelabs/wazero@v1.8.2...v1.9.0) --- updated-dependencies: - dependency-name: github.com/tetratelabs/wazero dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Naireen <[email protected]>
* Fix expansion service parsing in Python SDK for rc build * Fix format
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 27.5.1+incompatible to 28.0.1+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v27.5.1...v28.0.1) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) Bumps [github.com/go-sql-driver/mysql](https://github.com/go-sql-driver/mysql) from 1.8.1 to 1.9.0. - [Release notes](https://github.com/go-sql-driver/mysql/releases) - [Changelog](https://github.com/go-sql-driver/mysql/blob/master/CHANGELOG.md) - [Commits](go-sql-driver/mysql@v1.8.1...v1.9.0) --- updated-dependencies: - dependency-name: github.com/go-sql-driver/mysql dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updated the docstring to include a clear example of how to enable t the legacy mode (ReadFromKafkaViaUnbounded) in the ReadFromKafka transform. This helps users switch from the default mode (ReadFromKafkaViaSDF) based connector to the legacy connector for scenarios requiring fewer Kafka connections.
) Bumps [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2) from 1.36.1 to 1.36.3. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json) - [Commits](aws/aws-sdk-go-v2@v1.36.1...v1.36.3) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Split tests need mockStatic outside of DataflowTest To be able to run DataflowTest internally which did not support mockStatic * Remove usage of powermock for GcpIO, KafkaIO, DataflowRunner tests * Minimize powermock dependency for Flink runner
* update containers * rollback fnapi change * update fnapi
Co-authored-by: Naireen <[email protected]>
* Add log4j2 deps for spark validatesRunner tasks. * Trigger spark postcommit tests.
* Update JdbcIO.java * Fix vars * Fix typing problems * Use lineage check so that we maintain safety * Remove dupe assignment * Assign correctly inside lock to avoid race * Add other getConnection * Fix bad merge * Remove unneeded logs * Shrink critical section * Cleanup * Fix bad refactor * typo
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by Sourcery
This pull request fixes a typo and enhances the
OffsetHolder
class by overriding theequals
andhashCode
methods to ensure proper comparison ofOffsetHolder
objects. It also includes a new test case to verify the correctness of theequals
method in theOffsetHolder
class.Bug Fixes:
milisecondsToRun
, which was corrected tomillisecondsToRun
for consistency.Enhancements:
OffsetHolder
class by overriding theequals
andhashCode
methods to ensure proper comparison ofOffsetHolder
objects, especially when dealing with byte array lists.OffsetHolder
class to usebyte[]
instead ofObject
for the history to avoid casting.Tests:
testKafkaOffsetHolderEquality
, to verify the correctness of theequals
method in theOffsetHolder
class.