Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from apache:master #17

Open
wants to merge 47 commits into
base: master
Choose a base branch
from
Open

Conversation

pull[bot]
Copy link

@pull pull bot commented Feb 25, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

This pull request fixes a typo and enhances the OffsetHolder class by overriding the equals and hashCode methods to ensure proper comparison of OffsetHolder objects. It also includes a new test case to verify the correctness of the equals method in the OffsetHolder class.

Bug Fixes:

  • Fixes a typo in the parameter name milisecondsToRun, which was corrected to millisecondsToRun for consistency.

Enhancements:

  • Improves the OffsetHolder class by overriding the equals and hashCode methods to ensure proper comparison of OffsetHolder objects, especially when dealing with byte array lists.
  • Updates the OffsetHolder class to use byte[] instead of Object for the history to avoid casting.

Tests:

  • Adds a new test case, testKafkaOffsetHolderEquality, to verify the correctness of the equals method in the OffsetHolder class.

@pull pull bot added the ⤵️ pull label Feb 25, 2025
Copy link

sourcery-ai bot commented Feb 25, 2025

Reviewer's Guide by Sourcery

This pull request fixes a typo in the KafkaSourceConsumerFn class and adds an equality test for the OffsetHolder class.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Fixes a typo in the KafkaSourceConsumerFn class where milisecondsToRun was misspelled.
  • Renames milisecondsToRun to millisecondsToRun in the constructor.
  • Updates the getInitialRestriction method to use the corrected name.
  • Updates the process method to use the corrected name.
  • Updates the OffsetHolder class to use the corrected name.
sdks/java/io/debezium/src/main/java/org/apache/beam/io/debezium/KafkaSourceConsumerFn.java
Adds an equality test for the OffsetHolder class.
  • Adds a new test method testKafkaOffsetHolderEquality to verify the equality of OffsetHolder instances.
  • The test covers different scenarios, including null values, different map and list contents, and different fetched records and max records values.
sdks/java/io/debezium/src/test/java/org/apache/beam/io/debezium/KafkaSourceConsumerFnTest.java
Changes the type of the history field in OffsetHolder from List<?> to List<byte[]>.
  • Updates the type of the history field in OffsetHolder to be a list of byte arrays.
  • This change ensures that the history is stored as byte arrays, which is the correct type for the data being stored.
sdks/java/io/debezium/src/main/java/org/apache/beam/io/debezium/KafkaSourceConsumerFn.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

gitstream-cm bot commented Feb 25, 2025

🚨 gitStream Monthly Automation Limit Reached 🚨

Your organization has exceeded the number of pull requests allowed for automation with gitStream.
Monthly PRs automated: 2224/250

To continue automating your PR workflows and unlock additional features, please contact LinearB.

Copy link

coderabbitai bot commented Feb 25, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

scwhittle and others added 8 commits February 25, 2025 13:19
…ces. (#33901)

add a utility class to enable sharing across all deserialized instances of a DoFn and use it in UnboundedSourceAsSdfWrapperFn to cache Readers across dofn instances
* Add threshold and aggregation functions.

Also include the following changes:
* change prediction to predictions (iterable) in AnomalyResult.
* fix some tests that contaminate _KNONW_SPECIFIABLE

* Fix lints.

* Get rid of _run_init. The init will be called just-in-time.

* Add logic to handle missing and error labels/scores.

Also includes the following adjustments per reviewer's feedback
- Rename include_history to include_source_predictions.
- Get rid of the unnecessary cast

* Fix lints.
Bumps [github.com/tetratelabs/wazero](https://github.com/tetratelabs/wazero) from 1.8.2 to 1.9.0.
- [Release notes](https://github.com/tetratelabs/wazero/releases)
- [Commits](tetratelabs/wazero@v1.8.2...v1.9.0)

---
updated-dependencies:
- dependency-name: github.com/tetratelabs/wazero
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@github-actions github-actions bot added the go label Feb 25, 2025
@github-actions github-actions bot added the gcp label Feb 26, 2025
Abacn and others added 7 commits February 26, 2025 22:41
* Fix expansion service parsing in Python SDK for rc build

* Fix format
)

* Allow users to specify custom audit entries in pipeline options.

* Add sanity check on custom audit entries during pipeline option parsing.

* Fix lints and typos.

* Add docstring

* Change the flag to snake case.
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 27.5.1+incompatible to 28.0.1+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v27.5.1...v28.0.1)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
)

Bumps [github.com/go-sql-driver/mysql](https://github.com/go-sql-driver/mysql) from 1.8.1 to 1.9.0.
- [Release notes](https://github.com/go-sql-driver/mysql/releases)
- [Changelog](https://github.com/go-sql-driver/mysql/blob/master/CHANGELOG.md)
- [Commits](go-sql-driver/mysql@v1.8.1...v1.9.0)

---
updated-dependencies:
- dependency-name: github.com/go-sql-driver/mysql
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Updated the docstring to include a clear example of how to enable t the legacy mode (ReadFromKafkaViaUnbounded) in the ReadFromKafka transform. This helps users switch from the default mode (ReadFromKafkaViaSDF) based connector to the legacy connector for scenarios requiring fewer Kafka connections.
clairemcginty and others added 4 commits February 27, 2025 19:13
…cRecordToStorageApiProto (#34059)

* (fix #34038) Use CivilTimeEncoder to encode Time values in AvroGenericRecordToStorageApiProto

* Update CHANGES

* Don't throw away precision
)

Bumps [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2) from 1.36.1 to 1.36.3.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/main/changelog-template.json)
- [Commits](aws/aws-sdk-go-v2@v1.36.1...v1.36.3)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Split tests need mockStatic outside of DataflowTest
  To be able to run DataflowTest internally which did not support mockStatic

* Remove usage of powermock for GcpIO, KafkaIO, DataflowRunner tests

* Minimize powermock dependency for Flink runner
jrmccluskey and others added 7 commits February 28, 2025 11:09
)

* Update routing of types into convert_to_beam_type in normalize()

* fix typo

* add some quick test cases
* update containers

* rollback fnapi change

* update fnapi
Co-authored-by: Naireen <[email protected]>
* Add log4j2 deps for spark validatesRunner tasks.

* Trigger spark postcommit tests.
* Update JdbcIO.java

* Fix vars

* Fix typing problems

* Use lineage check so that we maintain safety

* Remove dupe assignment

* Assign correctly inside lock to avoid race

* Add other getConnection

* Fix bad merge

* Remove unneeded logs

* Shrink critical section

* Cleanup

* Fix bad refactor

* typo
@github-actions github-actions bot added the jdbc label Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.