Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package visibility in Android 11 for Expo projects #323

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

ytakzk
Copy link

@ytakzk ytakzk commented Oct 10, 2022

Some functions such as openFit() and isAvailable(callback) didn't work on Android 11 for apps built with Expo.

This is simply because queries does not contain Google Fit, but the issue is adding an item to queries is not so easy for Expo projects.

I am not sure how non-expo projects work, but it would be nice see Google Fit added to the query in the AndroidManifest.xml if this doesn't affect non-Expo projects.

@ytakzk ytakzk changed the title Update AndroidManifest.xml Package visibility in Android 11 for Expo projects Oct 10, 2022
@ytakzk
Copy link
Author

ytakzk commented Oct 11, 2022

#312

@aboveyunhai
Copy link
Collaborator

aboveyunhai commented Oct 16, 2022

@ytakzk
For non-expo project, they can add whatever they want into AndroidManifest in app level (inside your own project source code), so they can have full control , which I believe expo project should have the same configs.

check the doc: https://github.com/StasDoskalenko/react-native-google-fit#android-11

A lot of devs just don't notice it was in doc.

aboveyunhai and others added 23 commits November 5, 2022 16:11
…d-data

Flag manually added data on CalorieHistory & HealthHistory
Added guide about client secret json file
* hack

* issue-225 possible fix
Bumps [@sideway/formula](https://github.com/sideway/formula) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/sideway/formula/releases)
- [Commits](hapijs/formula@v3.0.0...v3.0.1)

---
updated-dependencies:
- dependency-name: "@sideway/formula"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [json5](https://github.com/json5/json5) from 2.2.1 to 2.2.3.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v2.2.1...v2.2.3)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md)
- [Commits](caolan/async@v2.6.3...v2.6.4)

---
updated-dependencies:
- dependency-name: async
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [decode-uri-component](https://github.com/SamVerschueren/decode-uri-component) from 0.2.0 to 0.2.2.
- [Release notes](https://github.com/SamVerschueren/decode-uri-component/releases)
- [Commits](SamVerschueren/decode-uri-component@v0.2.0...v0.2.2)

---
updated-dependencies:
- dependency-name: decode-uri-component
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [react-devtools-core](https://github.com/facebook/react/tree/HEAD/packages/react-devtools-core) from 4.25.0 to 4.28.4.
- [Release notes](https://github.com/facebook/react/releases)
- [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/react/commits/HEAD/packages/react-devtools-core)

---
updated-dependencies:
- dependency-name: react-devtools-core
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.18.9 to 7.23.2.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse)

---
updated-dependencies:
- dependency-name: "@babel/traverse"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…tasDoskalenko#338)

* Added the inLocalTimeZone parameter to the prepareResponse function. This defaults to false (existing behaviour) so is backwards compatible.
When inLocalTimeZone = false, dates are returned in the format: "endDate":"2022-12-22T16:51:30.000Z"
When inLocalTimeZone = true, dates are returned in the format: "endDate":"2022-12-22T11:51:30.000-0500"

This allows performance improvements, because you don't have to perform further date processing on the values to convert them back into the local time zone.

This PR adds the flag as a parameter to getSleepSamples. It can easily be added to other functions as required.

* Added logging to test running in app code

* Added the code to retrieve aggregated heart rates.

* Fixed call to get health history.

* Added extra logging

* Fixed reading values and removed logging

* Removed more logging.

* Fixed issue where all values were overwriting the average.

* Fixed a typo.

* Added the 'in local timezone' option to aggregated heart rates
* Migrate to yarn, update README.md

* 0.20.0

* npm publish

---------

Co-authored-by: Stas Doskalenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants