Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ompp build docs #1926

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Ompp build docs #1926

merged 3 commits into from
Dec 19, 2023

Conversation

Souheil-Yazji
Copy link
Contributor

No description provided.

@bryanpaget
Copy link
Contributor

Looking good. What about the French translation?

@bryanpaget bryanpaget added the kind/docs Improvements or additions to documentation label Dec 18, 2023
@Souheil-Yazji
Copy link
Contributor Author

Looking good. What about the French translation?

I actually need to make a separate issue for all Microsim related french docs

@bryanpaget
Copy link
Contributor

Looking good. What about the French translation?

I actually need to make a separate issue for all Microsim related french docs

I translated one already, #1927

@bryanpaget bryanpaget self-requested a review December 18, 2023 21:26
bryanpaget
bryanpaget approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@bryanpaget bryanpaget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Souheil-Yazji Souheil-Yazji merged commit bf7ca99 into master Dec 19, 2023
0 of 2 checks passed
@Souheil-Yazji Souheil-Yazji deleted the ompp-build-docs branch December 19, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanpaget bryanpaget bryanpaget approved these changes

Assignees
No one assigned
Labels
kind/docs Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Souheil-Yazji @bryanpaget