Skip to content

Commit

Permalink
feat(sidecar-terminator): Sync with improvements from 1.3.0 (#459)
Browse files Browse the repository at this point in the history
* feat(sidecar-terminator): Sync with improvements from 1.3.0

* feat(sidecar-terminator): Sync with improvements from 1.3.0

---------

Co-authored-by: will.hearn <[email protected]>
  • Loading branch information
sylus and statcan-svc authored Nov 30, 2023
1 parent dda6a2b commit a5cc48f
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 5 deletions.
5 changes: 3 additions & 2 deletions stable/sidecar-terminator/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,13 @@ appVersion: "1.0.0"
description: |-
A chart used for easily configuring kubernetes-sidecar-terminator in a cluster.
name: sidecar-terminator
version: 1.2.1
version: 1.2.2
keywords:
- sidecar-terminator
sources:
- https://gitlab.k8s.cloud.statcan.ca/cloudnative/terraform/modules/terraform-kubernetes-sidecar-terminator
- https://github.com/statcan/kubernetes-sidecar-terminator
maintainers:
- name: Mohamed Dahrouj
email: [email protected]
home: https://www.statcan.gc.ca
kubeVersion: ">= 1.23"
11 changes: 9 additions & 2 deletions stable/sidecar-terminator/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,15 @@ spec:
strategy: {}
template:
metadata:
{{- with .Values.podAnnotations }}
annotations:
{{- toYaml . | nindent 8 }}
{{- end }}
labels:
app.kubernetes.io/name: {{ include "sidecar-terminator.fullname" . }}
{{- include "sidecar-terminator.labels" . | nindent 8 }}
{{- with .Values.podLabels }}
{{- toYaml . | nindent 8 }}
{{- end }}
spec:
{{- with .Values.imagePullSecrets }}
imagePullSecrets:
Expand All @@ -24,7 +31,7 @@ spec:
priorityClassName: {{ .Values.priorityClassName }}
{{- end }}
containers:
- image: {{ .Values.image.repository }}
- image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
name: sidecar-terminator
args:
- '--lock-namespace'
Expand Down
7 changes: 6 additions & 1 deletion stable/sidecar-terminator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,13 @@

replicaCount: 1

# Annotations to add to the Pod
podAnnotations: {}
# Labels to add to the Pod
podLabels: {}

image:
repository: zachomedia/kubernetes-sidecar-terminator
repository: statcan/kubernetes-sidecar-terminator
pullPolicy: IfNotPresent
# Overrides the image tag whose default is the chart appVersion.
tag: ""
Expand Down

0 comments on commit a5cc48f

Please sign in to comment.