remove duplication in precompile_bmcm_model

StatisticsHealthEconomics · Aug 12, 2024 · 9e7d740 · 9e7d740
1 parent caf1940
commit 9e7d740
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 11 deletions.
diff --git a/R/bmcm_stan.R b/R/bmcm_stan.R
@@ -226,9 +226,12 @@ compile_model <- function(use_cmdstanr, model_code, model_name) {
     model_path <-
       cmdstanr::write_stan_file(
         model_code, dir = ".", basename = model_name)
-    return(cmdstanr::cmdstan_model(stan_file = model_path))
+    return(cmdstanr::cmdstan_model(stan_file = model_path, compile = TRUE))
   } else {
-    return(rstan::stan_model(model_code = model_code, model_name = model_name))
+    out <- rstan::stan_model(model_code = model_code, model_name = model_name)
+    saveRDS(precompiled_model, file = glue::glue("{model_name}.RDS"))
+
+    return(out)
   }
 }
 

diff --git a/R/precompile_bmcm_model.R b/R/precompile_bmcm_model.R
@@ -38,14 +38,7 @@ precompile_bmcm_model <- function(input_data,
       paste0("bmcm_stan_", glue::glue_collapse(distns, sep = "_"))
   }
 
-  if (use_cmdstanr) {
-    model_path <- cmdstanr::write_stan_file(model_code, dir = ".", basename = model_name)
-    precompiled_model <- cmdstanr::cmdstan_model(stan_file = model_path, compile = TRUE)
-  } else {
-    precompiled_model <- rstan::stan_model(model_code = model_code,
-                                           model_name = model_name)
-    saveRDS(precompiled_model, file = glue::glue("{model_name}.RDS"))
-  }
+  out <- compile_model(use_cmdstanr, model_code, model_name)
 
-  invisible(precompiled_model)
+  invisible(out)
 }