Blacklisted queues should not send general metrics #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the middleware is called and a blacklisted queue is referenced, we should short-circuit processing altogether and not even query/report the general set of metrics.
jayzes
force-pushed
the
jz-blacklisted-queues-should-send-no-metrics
branch
from
28857b4 to
1cb6994
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into an issue where some of our queues tend to spin up a large number of small/fast jobs, and the overhead associated with the metrics middleware was causing a substantial slowdown in clearing those queues, even when the queue in question was blacklisted. Digging in, I noticed that blacklisting a queue doesn't completely prevent metrics from being reported - it just short-circuits the detailed reporting, but still triggers the general stats. This PR changes that behavior so that nothing will get reported when the middleware is processing a blacklisted queue.