Fix excessive reconfigure #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkle
commented
Jan 18, 2016
urkle
commented
- a bit of cleanup of how librato-sidekiq configuration is done
- sidekiq "initializes" the middleware once per each thread so having the initialize re-register is a BAD idea.
- now a separate Configuration class exists
- configuration method is not on Librato::Sidekiq.configure and will now reload the middleware ONLY when reconfigured
- fixed version checking of Librato::Rails
…that - no longer do the middleware reconfigure themselves on init - this is BAD as sidekiq allocates new middleware PER thread!! - centralize configuration to a single concise class - move registration of the middleware to new module level code in Librato::Sidekiq - fix checking for librato rails version # (current is 1.1.0 which failed the LIBRATO_AUTORUN check)
|
This is a cleaner approach to fixing the issue described in #8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.