Skip to content

Commit

Permalink
[KYUUBI apache#4606] [K8S][HELM] Add command and args configuration s…
Browse files Browse the repository at this point in the history
…upport

### _Why are the changes needed?_
The change allows to change default command to launch Kyuubi and pass additional command line arguments.
It's needed if the chart user wants to print message, create files or similar in main container (`kyuubi-server`) when pod starts.

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request

Closes apache#4606 from dnskr/add_command_and_args.

Closes apache#4606

5e0ba5b [dnskr] [K8S][HELM] Add command and args configuration support

Authored-by: dnskr <[email protected]>
Signed-off-by: Cheng Pan <[email protected]>
  • Loading branch information
dnskr authored and pan3793 committed Mar 26, 2023
1 parent 5e541fa commit 5c90e84
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
6 changes: 6 additions & 0 deletions charts/kyuubi/templates/kyuubi-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@ spec:
- name: kyuubi-server
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
{{- with .Values.command }}
command: {{- tpl (toYaml .) $ | nindent 12 }}
{{- end }}
{{- with .Values.args }}
args: {{- tpl (toYaml .) $ | nindent 12 }}
{{- end }}
{{- with .Values.env }}
env: {{- tpl (toYaml .) $ | nindent 12 }}
{{- end }}
Expand Down
5 changes: 5 additions & 0 deletions charts/kyuubi/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,11 @@ kyuubiConf:
# See example at conf/log4j2.xml.template https://kyuubi.readthedocs.io/en/master/deployment/settings.html#logging for more details
log4j2: ~

# Command to launch Kyuubi server (templated)
command: ~
# Arguments to launch Kyuubi server (templated)
args: ~

# Environment variables (templated)
env: []
envFrom: []
Expand Down

0 comments on commit 5c90e84

Please sign in to comment.