Fix get_table() call hangups with docker #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check_snmp_storage.pl executions may hang (checked on Debian 11/12) while querying host with docker filesystems with many long filesystem mountpoints like ``` iso.3.6.1.2.1.25.2.3.1.3.1 = STRING: "Physical memory" iso.3.6.1.2.1.25.2.3.1.3.3 = STRING: "Virtual memory" iso.3.6.1.2.1.25.2.3.1.3.6 = STRING: "Memory buffers" iso.3.6.1.2.1.25.2.3.1.3.7 = STRING: "Cached memory" iso.3.6.1.2.1.25.2.3.1.3.8 = STRING: "Shared memory" iso.3.6.1.2.1.25.2.3.1.3.10 = STRING: "Swap space" iso.3.6.1.2.1.25.2.3.1.3.35 = STRING: "/run" iso.3.6.1.2.1.25.2.3.1.3.36 = STRING: "/" iso.3.6.1.2.1.25.2.3.1.3.38 = STRING: "/dev/shm" iso.3.6.1.2.1.25.2.3.1.3.39 = STRING: "/run/lock" iso.3.6.1.2.1.25.2.3.1.3.40 = STRING: "/sys/fs/cgroup" iso.3.6.1.2.1.25.2.3.1.3.59 = STRING: "/test1" iso.3.6.1.2.1.25.2.3.1.3.60 = STRING: "/test2" iso.3.6.1.2.1.25.2.3.1.3.61 = STRING: "/test3" iso.3.6.1.2.1.25.2.3.1.3.64 = STRING: "/var/lib/docker/containers/43b4ba50f14279701a4d13333e00a26375aa114b9100d845044107cbcd5ce4a0/mounts/shm" iso.3.6.1.2.1.25.2.3.1.3.66 = STRING: "/var/lib/docker/containers/5f62f6600a81d7c8b116a134853d9b445711d3a9e79935ded1831c09cab5d6176/mounts/shm" iso.3.6.1.2.1.25.2.3.1.3.68 = STRING: "/var/lib/docker/containers/7ddef6926988082e6c5d33bdf8544cf7659f85e760587111c3737f2addc04d60a/mounts/shm" [...] ``` It was tested that issue does not occur if `get-next-requests` is used instead of `get-bulk-requests`. This fix forces `get-next-requests` to be used in problematic call. Related: https://metacpan.org/pod/Net::SNMP#get_table()-retrieve-a-table-from-the-remote-agent Author-Change-Id: IB#1089430
check_snmp_storage.pl plugin code tided. Fixes: 35e9ec4 Related: https://github.com/SteScho/manubulon-snmp?tab=readme-ov-file#contributing Author-Change-Id: IB#1089430
Fixes: 35e9ec4 Author-Change-Id: IB#1089430
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_snmp_storage.pl executions may hang (checked on Debian 11/12)
while querying host with docker filesystems with many long filesystem
mountpoints like
It was tested that issue does not occur if
get-next-requestsis used instead ofget-bulk-requests. This fix forcesget-next-requeststo be used in problematic call.Plugin code was tided also in 3f31d36.
Related: https://metacpan.org/pod/Net::SNMP#get_table()-retrieve-a-table-from-the-remote-agent
Author-Change-Id: IB#1089430