fix: ci is not checking out submodule version but using the must recent version. Bypassing the audit. And better pr ci #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt version. Bypassing the audit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a issue where the ci did not pull the submodule version but just pulled the most recent version of the repo which means it fully bypassed the whole audit system. This can be seen an the steamdb plugin, its submodule has the sha 3a911f4 which is an old commit where the version was 1.0.3 but if you check the most recent artifact is has version 1.2.0 which is the most recent commit at that time.
I will follow up this pr with a pr to update my submodules.
Also fixed the pr ci by just running the main ci without the database stuff. So now you can see/test the build on the pr already.
Let me know if this is an unwanted feature.