Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spring Boot Admin pipeline, update SBA, Eureka and Config Server deps #36

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Sep 24, 2024

Build SBA server via start.spring.io the same way our Eureka & Config Server images are built.
Switch to cURL and update all to the latest versions for all 3 images built from start.spring.io.
Also use different image names during PR builds to avoid unexpected overwrites in the image repository

Closes #14

@TimHess TimHess changed the title Revisit/Update Spring Boot Admin Image Add Spring Boot Admin pipeline, update SBA, Eureka and Config Server deps Sep 25, 2024
@TimHess TimHess force-pushed the spring-boot-admin branch 2 times, most recently from e4c3163 to cfdefad Compare September 25, 2024 19:43
.github/workflows/build_config_server.yaml Outdated Show resolved Hide resolved
.github/workflows/build_config_server.yaml Show resolved Hide resolved
.github/workflows/build_config_server.yaml Show resolved Hide resolved
build.ps1 Outdated Show resolved Hide resolved
spring-boot-admin/Dockerfile Show resolved Hide resolved
spring-boot-admin/README.adoc Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't offer a suggestion for this, but please update the title (line 7) to:

Image for SteeltoeOSS local development with https://cloud.spring.io/spring-cloud-netflix/[Spring Cloud Eureka Server].

.github/workflows/build_config_server.yaml Outdated Show resolved Hide resolved
Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One textual update is still missing.

…-DirectoryName addition, update readme files, use alpine for config server running image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create pipelines for each image
2 participants