-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spring Boot Admin pipeline, update SBA, Eureka and Config Server deps #36
base: main
Are you sure you want to change the base?
Conversation
Also: move from HTTPIE to CURL and append "-pr" to image name during PR builds
36bdcb3
to
95e050a
Compare
e4c3163
to
cfdefad
Compare
cfdefad
to
fd082e0
Compare
e0e0845
to
cdc2ef7
Compare
eureka-server/README.adoc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't offer a suggestion for this, but please update the title (line 7) to:
Image for SteeltoeOSS local development with https://cloud.spring.io/spring-cloud-netflix/[Spring Cloud Eureka Server].
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One textual update is still missing.
…-DirectoryName addition, update readme files, use alpine for config server running image
cdc2ef7
to
495f6c4
Compare
Build SBA server via start.spring.io the same way our Eureka & Config Server images are built.
Switch to cURL and update all to the latest versions for all 3 images built from start.spring.io.
Also use different image names during PR builds to avoid unexpected overwrites in the image repository
Closes #14