Exposed RelationalDatabaseHealthContributor #1595
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes
Steeltoe.Connectors.RelationalDatabaseHealthContributor
public and adds a way to override theId
property andCommandText
used to check the DB (default is "SELECT 1;")The goal of this is to make it easier to implement custom health checks for non-supported databases (like Oracle).
Fixes #1594
EDIT: another benefit is that this would make it possible to add a supported DB to Steeltoe's healthcheck chain without registering it through Steeltoe's connector itself (connectionString managed manually)
Quality checklist
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.