Skip to content

Conversation

Levyks
Copy link

@Levyks Levyks commented Sep 13, 2025

Description

Makes Steeltoe.Connectors.RelationalDatabaseHealthContributor public and adds a way to override the Id property and CommandText used to check the DB (default is "SELECT 1;")

The goal of this is to make it easier to implement custom health checks for non-supported databases (like Oracle).

Fixes #1594

EDIT: another benefit is that this would make it possible to add a supported DB to Steeltoe's healthcheck chain without registering it through Steeltoe's connector itself (connectionString managed manually)

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@Levyks
Copy link
Author

Levyks commented Sep 13, 2025

@dotnet-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make RelationalDatabaseHealthContributor public and generic
1 participant