WIP: write stock back to magento, implement tax sync #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that pricelists can also be used to just import orders in different currencies per website.
We have had large contributions to migrate the connector to Odoo 8.0. It's only fair to add them on the financial contributor page.
…e_prices [RFR] Make pushing prices to Magento optional
Add financial contributors for Odoo 8.0 migration
|
Sorry, I missed this one. Can you split up the tax part into another PR, as it is out of scope for the target magento2 branch until it's merged (if ever). |
| @@ -153,15 +154,14 @@ def delete(self, id): | |||
| """ Delete a record on the external system """ | |||
| raise NotImplementedError | |||
|
|
|||
| def _call(self, method, arguments=None, http_method=None, storeview=None): | |||
There was a problem hiding this comment.
Why did you choose to duplicate this method?
| partner_id = partner_binder.to_openerp(record['customer_id']) | ||
| if partner_id: | ||
| partner_binding = partner_obj.browse(partner_id) | ||
| partner_binding.write(map_record.values()) |
There was a problem hiding this comment.
The commit in which you changed this is called 'Dont overwrite partner if its already in the system'. But it looks like this is exactly what you are doing. Am I missing something? BTW this is not specific to Magento2 so I think it is out of scope for this PR.
| ondelete='restrict') | ||
| # We should be able to delete products, | ||
| # even when they have an equivalent in Magento. | ||
| ondelete='cascade') |
There was a problem hiding this comment.
Not specific to magento2, out of scope for this PR
| @@ -263,7 +267,7 @@ def write(self, id, data, storeview_id=None): | |||
| # XXX actually only ol_catalog_product.update works | |||
| # the PHP connector maybe breaks the catalog_product.update | |||
| if self.magento.version == '2.0': | |||
| raise NotImplementedError # TODO | |||
| return super(ProductProductAdapter, self).write(id, data) | |||
There was a problem hiding this comment.
Did you not encounter magento/magento2#3354? I certainly did. I think I emailed you my workaround?
[IMP] Bind imported products to existing ones with the same code
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
… stuck on that it cannot choose between the inherited and the real Mapper/importer - how to extend?
thomaspaulb
force-pushed
the
8.0-magento2-stock-writeback-and-tax
branch
from
9ba3cf4
to
bda2f15
Compare
StefanRijnhart
added a commit
that referenced
this pull request
Sep 8, 2021
``` 2020-11-05 13:36:35,202 6822 INFO openerp_test odoo.tests: skip sending email in test mode 2020-11-05 13:36:35,206 6822 INFO openerp_test odoo.addons.mail.models.mail_mail: Mail with ID 1 and Message-Id '<342741149332557.1604583395.110157728195190-openerp-1-connector.checkpoint@travis-job-14c1db44-ca6c-40e2-82ff-03dcf3df66dc>' successfully sent 2020-11-05 13:36:35,227 6822 INFO openerp_test odoo.models.unlink: User #1 deleted mail.mail records with IDs: [1] 2020-11-05 13:36:35,228 6822 INFO openerp_test odoo.addons.mail.models.mail_mail: Sent batch 1 emails via mail server ID #False ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stock part is kind of ready for review. The tax part imports tax classes well, but I still want to have product depend on tax class and tax class on tax rate, and implement import of tax rate.