docs(adr): add private access threat model and Stellar feasibility ADR - #21
Open
Tobiloba0 wants to merge 1 commit into
Open
docs(adr): add private access threat model and Stellar feasibility ADR#21Tobiloba0 wants to merge 1 commit into
Tobiloba0 wants to merge 1 commit into
Conversation
Joaco2603
requested changes
Jul 20, 2026
Joaco2603
left a comment
Collaborator
There was a problem hiding this comment.
Buen trabajo cubriendo los adversarios y las alternativas pedidas en #19. Antes de aprobar necesito que ajustes el ADR:
- Aclará el límite de garantía del enfoque recomendado: mientras
buy_prompt(buyer, prompt_id)yhas_access(user, prompt_id)mantengan sus argumentos, storage y evento públicos, la entrega cifrada off-chain NO puede preservar una verificación de entitlement on-chain que oculte el vínculo buyer↔prompt. Esa frase de la recomendación debe reemplazarse por una limitación explícita; la unlinkability on-chain queda fuera de alcance hasta diseñar commitments/proofs. - Convertí el ciclo de claves en un protocolo verificable: definí cómo se obtiene y autentica una clave pública de cifrado distinta de la clave de firma Stellar, quién puede ver plaintext y claves de contenido, y cómo re-encriptación/revocación/migración funcionan cuando se rota una clave. “wallet-controlled secrets” y “backend does not store plaintext long-term” hoy no fijan esa frontera de confianza.
- Agregá criterios de aceptación verificables para la opción recomendada (por ejemplo: campos/logs prohibidos, pruebas de replay y la evidencia concreta que debe aportar Backend #8).
Además, por favor agregá el label type:docs; el workflow actual no se dispara para cambios bajo docs/**, así que el ADR debe ser suficientemente preciso para una revisión manual.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19
Adds a new Architectural Decision Record at 0001-private-access-threat-model.md
Defines private access goals and attacker capabilities for the current Soroban marketplace
Documents leakage vectors across arguments, auth entries, storage, events, token activity, metadata, and timing
Evaluates candidate approaches: encrypted off-chain delivery, opaque access records, relayers, and zero-knowledge proofs
Recommends delaying any private-access registry until this ADR is reviewed and approved
Includes anti-replay, key lifecycle, delivery, migration, and test evidence guidance
Closes #19