Merged
Conversation
|
@BernardOnuh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
🎉 This PR is included in version 1.21.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dx: add devcontainer for instant contributor onboarding
Closes #216
Summary
Adds a
.devcontainer/devcontainer.jsonso any contributor can start coding immediately in a fully pre-configured environment — locally in VS Code or one-click via GitHub Codespaces. No manual toolchain setup required.What's included
mcr.microsoft.com/devcontainers/rust:1-bookworm(official MS devcontainer image)cp .env.example .env→npm install→cargo build(server + cli)Acceptance criteria
.devcontainer/devcontainer.jsonwith Node v20 and Rust stablenpm installandcargo build.env.examplecopied to.envautomatically on container creationImplementation notes
.envcopy usescp -n(no-clobber) so it never overwrites an existing.envif the container is rebuiltremoteUser: vscodeensures the container runs as non-root, following devcontainer best practiceeditor.formatOnSavewired up with correct per-language formatters (Prettier for TS/JS, rust-analyzer for Rust)How to test
GitHub Codespaces:
https://github.com/BernardOnuh/fluidnode -voutputsv20.x,rustc --versionoutputs a stable version.envexists and extensions are active in the sidebarVS Code locally: