security(crypto): make content-encryption keys non-extractable by default (#1691) - #1763
Open
wolfyres wants to merge 3 commits into
Open
security(crypto): make content-encryption keys non-extractable by default (#1691)#1763wolfyres wants to merge 3 commits into
wolfyres wants to merge 3 commits into
Conversation
Remove unnecessary comment from content-key.ts
Added tests to verify the behavior of non-extractable content encryption keys, including generation, export failure, and encryption/decryption functionality.
Author
|
CI issue has been fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1691
This PR updates content key generation in
src/services/crypto/content-key.tsto default toextractable: false. This ensures raw key material cannot be accidentally exposed or exported outside the crypto wrapping boundary.Changes Introduced
generateContentKey()options soextractabledefaults tofalse.src/services/crypto/wrapping boundaries.src/services/crypto/__tests__/content-key.test.tsasserting:extractableproperty isfalseby default.crypto.subtle.exportKey('raw', key)rejects as expected.Checklist
extractable === false).CryptoKeyinstances.src/services/crypto/.Verification / Testing
Run crypto unit tests:
npm test src/services/crypto