Improve/postage api optimization - #1881
Open
oraimoitel wants to merge 3 commits into
Open
Conversation
Expand unit tests for filterAuditEvents, hasActiveAuditFilter, formatEventAsText, and CATEGORY_FOR_KIND from 7 to 21 tests. Add Playwright E2E spec covering event rendering, category filtering, search, empty states, copy/export buttons, and count.
Add regression coverage for audit log feature Closes Stellar-Mail#964
Hotspot identified: MemoryApiRepository.incrementCounter() allocated 3 temporary arrays per call (spread-copy, Array(n).fill, filter). Called 5x per submitPostage request = 15 arrays per request. Changes: - memory-repository.ts: Replace 3-array incrementCounter with single-pass push loop, eliminating all intermediate allocations. - postage-service.ts: Extract buildQuoteResult() to deduplicate identical recordAuditEvent calls in both quote branches.
Collaborator
|
Please add proper PR description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #948