docs(contacts): document import wizard safety boundaries and QA handoff - #1887
Open
prissca wants to merge 2 commits into
Open
docs(contacts): document import wizard safety boundaries and QA handoff#1887prissca wants to merge 2 commits into
prissca wants to merge 2 commits into
Conversation
…ff (closes Stellar-Mail#995) Adds src/features/contacts/README.md following the same contributor handoff format already used for audit-log and other feature folders: what each file in import/ owns, the ImportedContactRow data contract, safety notes (client-side-only parsing, malformed rows surfaced not dropped, fuzzy matches require manual confirmation, retention policy scope, no real user data in dev/demos), user-facing states, and a lightweight manual QA checklist. Also notes the current lack of automated test coverage for csvParser.ts/identityMatcher.ts rather than silently omitting it. No code changes — this issue is documentation-only per its acceptance criteria. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
prissca
marked this pull request as draft
July 27, 2026 04:20
kryputh
marked this pull request as ready for review
July 27, 2026 05:27
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documentation-only, per this issue's acceptance criteria:
src/features/contacts/import/implementationImportedContactRowdata contract and user-facing wizard statesThe issue's suggested filenames no longer match the live module layout, so this handoff links directly to the current implementation and tests instead of introducing a parallel architecture.
Validation
npm exec -- vitest run tests/unit/import— 4 files and 63 tests passedgit diff --checkCloses #995