[Contacts Import] Close keyboard and screen-reader gaps - #1904
Open
dotunv wants to merge 1 commit into
Open
Conversation
…acts Import - ContactMigrationDialog: focus trap, dialog ARIA, reduced-motion (MotionConfig), close button label, step live region - ImportSourcePicker: keyboard-accessible file upload zone, aria-hidden on decorative icons - IdentityReviewTable: tablist/tab roles, search aria-label, scrollable region, empty-state live region - BulkWriteProgressPanel: progressbar role, aria-hidden on decorative icons, error live region
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #992
Summary
Improve the existing Contacts Import surface by closing keyboard and screen-reader gaps identified during an a11y audit. All changes are in-place, no new components or tools introduced.
Changes
ContactMigrationDialog.tsx
useFocusTraphook for Tab/Shift+Tab trapping, Escape close, focus restorationrole="dialog",aria-modal="true",aria-label="Contact migration"to the panelaria-hidden="true"on backdrop;aria-label="Close dialog"on close button<MotionConfig reducedMotion="user">for reduced-motion supportaria-live="polite"on the step indicator for screen-reader step announcementsImportSourcePicker.tsx
role="button",tabIndex,onKeyDown)aria-hidden="true"to decorative icons throughoutIdentityReviewTable.tsx
role="tablist"/role="tab"/aria-selectedon filter buttonsaria-label="Search contacts"on the search inputrole="region"/aria-label="Contacts list"/tabIndex={0}on scrollable listaria-live="polite"on empty-state;aria-hidden="true"on decorative iconsBulkWriteProgressPanel.tsx
role="progressbar"witharia-valuenow/min/maxon the progress bararia-hidden="true"on all decorative status icons, count cards, and button iconsaria-live="polite"on the error region