Skip to content

Replace no-op API counter with production metrics adapter #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dotunv wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace no-op API counter with production metrics adapter #1905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 31 additions & 1 deletion src/server/api/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,16 @@ export function createRouteHandler<
mode = config.authMode;
}
if (mode === "required") {
actorId = requireActor(apiContext);
try {
actorId = requireActor(apiContext);
} catch (authError: any) {
metrics.incrementCounter("auth_failures_total", {
method,
path,
reason: authError?.code ?? "unauthorized",
});
throw authError;
}
} else if (mode === "optional") {
try {
actorId = requireActor(apiContext);
Expand All @@ -98,10 +107,20 @@ export function createRouteHandler<
if (config.authPolicy) {
// If policy requires an authenticated actor but none is present, fail closed
if (!actorId) {
metrics.incrementCounter("auth_failures_total", {
method,
path,
reason: "missing_actor",
});
throw new ApiError(401, "unauthorized", "Authentication required for policy evaluation");
}
const authorized = await Promise.resolve(config.authPolicy(actorId, request));
if (!authorized) {
metrics.incrementCounter("auth_failures_total", {
method,
path,
reason: "policy_rejected",
});
throw new ApiError(403, "forbidden", "Authorization policy rejected the request");
}
}
Expand All @@ -112,6 +131,11 @@ export function createRouteHandler<
let subject: string;
if (config.rateLimit.type === "account") {
if (!actorId) {
metrics.incrementCounter("auth_failures_total", {
method,
path,
reason: "rate_limit_no_auth",
});
throw new ApiError(401, "unauthorized", "Account rate limit requires authentication");
}
subject = actorId;
Expand All @@ -129,6 +153,12 @@ export function createRouteHandler<
config.rateLimit.operation,
);
if (!limit.allowed) {
metrics.incrementCounter("rate_limits_total", {
method,
path,
limit_type: config.rateLimit.type,
operation: config.rateLimit.operation,
});
throw new ApiError(
429,
"too_many_requests",
Expand Down
Loading