feat: add reentrancy guard to release, refund, and cancel_invoice - #541
Merged
Conversation
- Add ReentrantCall = 33 error variant to ContractError (stable discriminant) - Add reentrancy_lock_key() using temporary storage symbol "re_lock" - Add with_reentrancy_guard() closure helper - Wrap release_invoice, refund, and cancel_invoice with inline guard: check lock -> set lock -> run body -> clear lock on normal exit - Temporary storage ensures the lock is never persisted across transactions
|
@Keengfk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: reentrancy guard for release, refund, and cancel_invoice
Summary
Token transfer callbacks in Soroban can re-enter the contract if the token
contract is malicious or misconfigured. This PR protects all fund-moving entry
points with a reentrancy lock backed by temporary storage.
Changes
error.rs
(stable).
lib.rs
temporary storage key for the lock.
entry, runs the body, and clears it on exit.
error code.
Why temporary storage
Temporary storage is scoped to a single transaction and is automatically
discarded on abort. This means:
boundaries.
transaction state.
Acceptance criteria coverage
┌───────────┬────────┐
│ Criterion │ Status │
├──────────────────────────────────────────────────────┼────────┤
│ Nested calls to release_invoice return ReentrantCall │
└────────────────────────
closes #479