feat: add GitHub Actions lint workflow (#64)#92
Merged
ayomideadeniran merged 2 commits intoStellarDevHub:mainfrom Mar 25, 2026
Merged
Conversation
|
@cyber-excel10 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@cyber-excel10 Resolve Merge conflict then i can review. |
Contributor
|
@cyber-excel10 Please re-clone the repo and re-clone your current PR. The codebase has undergone significant structural and formatting changes for better stability and health. |
- Create .github/workflows/lint.yml with parallel jobs for frontend, backend, and contracts - Fix frontend lint script to use next lint, add prettier format:check - Add ESLint + TypeScript config and prettier to backend - Upgrade soroban-sdk 20.0.0 -> 22.0.0, fix Cargo.toml dev-dependencies typo - Add #[contracterror] to TokenError enum with explicit discriminants - Add shared .prettierrc at repo root All three lint jobs verified locally: - cargo clippy + rustfmt: clean - frontend eslint + prettier: clean - backend eslint + prettier: clean
39bdd70 to
5b65a65
Compare
Contributor
|
Impressive. |
Author
Thank You |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64
Description
Add comprehensive linting and formatting infrastructure across all three project layers (frontend, backend, smart contracts).
This PR establishes consistent code quality standards and automated checks to catch issues early in the development process.
Changes Made
CI/CD Pipeline
.github/workflows/lint.ymlwith parallel jobs for frontend, backend, and contractsFrontend
next lintinstead of invalid commandformatandformat:checkscripts using PrettierBackend
Smart Contracts
#[contracterror]attribute to TokenError enum with explicit discriminantsShared Configuration
.prettierrcat repo root with consistent formatting rules:semi: truesingleQuote: truetabWidth: 2trailingComma: "es5"printWidth: 100Verification
All three lint jobs verified locally:
cargo clippy --all-targets --all-features- cleancargo fmt --all -- --check- cleannpm run lint(frontend) - cleannpm run format:check(frontend) - cleannpm run lint(backend) - cleannpm run format:check(backend) - cleanType of Change
Checklist