fix(config): require secure WEBHOOK_SECRET configuration - #163
Merged
Manuel1234477 merged 1 commit intoJul 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses the security vulnerability where
WEBHOOK_SECRETdefaulted to a guessable, publicly-known literal value ("default-secret"). It removes the default fallback and implements a strict configuration validation flow at server startup. Additionally, this PR fixes a pre-existing compilation error in the payment rate limiter module.Changes
env_orhelper function insrc/config.rsand replaced it with explicit environment variables checks to prevent silently falling back to insecure or guessable defaults for sensitive configurations.validate_webhook_secrethelper to validateWEBHOOK_SECRETinConfig::from_env(). Validation fails fast at boot if the secret:"default-secret")..env.examplewith a dummy value of 32+ characters (default-development-webhook-signing-secret-32-chars) so that developers copying the example template have a valid config out-of-the-box.src/api/mod.rsthat referred to an undefined variable (rate_limit_rps) and a non-existent module (tower_http::util).Security Impact
Enforcing strict, fail-fast validation at boot prevents server instances from running without a configured webhook secret or with weak, guessable secrets, closing a vulnerability that could allow attackers to forge webhook signatures.
Testing Performed
testsmodule insrc/config.rs, validating each validation constraint (missing, empty, whitespace, guessable default, short secret, valid long secret, production startup failure, and successful startup).cargo test).cargo fmt -- --checkandcargo clippy --all-targets --all-features -- -D warnings).closes #68