feat: add webhook URL validation with configuration scheme allowlist - #208
Merged
Manuel1234477 merged 1 commit intoJul 25, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #129
What
Adds validation for
webhook_urlin the payments module by:ALLOWED_WEBHOOK_SCHEMESenvironment variablehttpswhen the environment variable is not setWhy
The previous implementation used hardcoded URL scheme validation and did not enforce the maximum URL length required by the issue. This change makes the validation more flexible while ensuring the missing length constraint is applied.
How to Test
Run with both HTTP and HTTPS enabled:
Run without setting
ALLOWED_WEBHOOK_SCHEMESto verify that onlyhttpsURLs are accepted.