feat: add Stellar challenge auth with JWT sessions#23
Merged
Jayrodri088 merged 1 commit intoStellarState:mainfrom Mar 27, 2026
Merged
feat: add Stellar challenge auth with JWT sessions#23Jayrodri088 merged 1 commit intoStellarState:mainfrom
Jayrodri088 merged 1 commit intoStellarState:mainfrom
Conversation
|
@Josue19-08 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements Stellar wallet challenge/verify authentication with JWT-backed sessions for the API.
Closes #2
Type of Change
Checklist
feat:,fix:,chore:, etc.) — enforced by CI.env, or credentials committed (seeCONTRIBUTING.md)Testing
How to Test
npm ci.JWT_SECRET,JWT_EXPIRES_IN,AUTH_CHALLENGE_TTL_MS,STELLAR_NETWORK, andDATABASE_URLin.env.npm run lint,npm run type-check,npm test, andnpm run build.POST /api/v1/auth/challenge, sign the returnedmessagewith the Stellar wallet private key, then submitPOST /api/v1/auth/verifyand callGET /api/v1/auth/mewith the bearer token.Test Coverage
Additional Notes
Changes
auth_challengespersistence plus a migration for nonce expiry and single-use enforcement.stellarAddress..env.exampleandReadme.mdwith the auth env vars and endpoint documentation.Refresh approach
This implementation uses short-lived access JWTs only and does not persist refresh tokens. When an access token expires, the client must request a new challenge and sign it again with the Stellar wallet. That keeps server-side session state minimal and avoids introducing a separate refresh-token table in this issue. The tradeoff is more frequent wallet signatures, but the flow stays simple and keeps replay protection centered on expiring single-use nonces.
Environment variables
JWT_SECRETJWT_EXPIRES_INAUTH_CHALLENGE_TTL_MSSTELLAR_NETWORKDATABASE_URLFor Reviewers