fix: localize and normalize timestamps across leaderboard views - #36
Open
CrazyShout wants to merge 3 commits into
Open
fix: localize and normalize timestamps across leaderboard views#36CrazyShout wants to merge 3 commits into
CrazyShout wants to merge 3 commits into
Conversation
Author
|
/claim #27 |
Author
|
Follow-up pushed in
Validation after the update:
|
Collaborator
|
@CrazyShout fix file conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The existing helper assumed every value was Unix seconds and hard-coded
en-US. Soroban events were stored as milliseconds, but the activity view multiplied them by 1,000 again. The leaderboard also did not expose or render a refresh timestamp, so there was no consistent timestamp display to localize.User impact
Leaderboard and activity timestamps now represent the correct instant, follow the user's browser locale and time zone, and identify that time zone explicitly. Failed leaderboard refreshes do not display a misleading new timestamp.
Validation
StellarPulsewhile the component rendersStellar Pulse.tsc --noEmitreports only the pre-existingsrc/app/layout.tsxGoogle Font configuration error (weightis required).git diff --checkpasses.The repository currently omits
frontend/package.json; local validation used a temporary manifest reconstructed from the committedpackage-lock.json. The manifest is not part of this PR.Closes #27