Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint with Google template #71

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add eslint with Google template #71

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 6, 2017 •
edited by ghost
Loading

Pivotal: https://www.pivotaltracker.com/story/show/143525005
Added eslint for checking Javascript files.

jacquesporveau
jacquesporveau reviewed Apr 6, 2017
View reviewed changes
Copy link
Member

@jacquesporveau jacquesporveau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I don't have any experience with setting up eslint.

@ghost ghost force-pushed the add_eslint branch 3 times, most recently from ac7c3ec to 7b7f31c Compare April 11, 2017 18:33
qr8r
qr8r suggested changes Apr 12, 2017
View reviewed changes
Copy link
Contributor

@qr8r qr8r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eslint output
✖ 31 problems (31 errors, 0 warnings)

@ghost ghost force-pushed the add_eslint branch from c5cc99d to 5f981eb Compare April 12, 2017 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qr8r @jacquesporveau @LeonTenko