Skip to content

Conversation

@mgkeen
Copy link
Contributor

@mgkeen mgkeen commented Jul 26, 2016

Don't know if you want to use this or not. I've updated the version of jwt-go to the latest. I was having dependency clashes in my project so needed it to reference latest jwt-go.

The biggest change was that claims was no longer a map[string]interface{}, so had to use the MapClaims type provided.

There was also a change in the way it validates expiry time, essentially treating a 0 value as if the claim wasn't specified. The test was previously using a zero value to test for a failed expiry, so i have adjusted that to pass up a value of 1 instead.

@StephanDollberg
Copy link
Owner

Hi @mgkeen ,

Thanks for the PR. This looks pretty great and I will definitely get started based on this.

However, if you have a look at the other open PRs, I want to integrate some breaking changes into the refactoring to v3 and consequently won't merge this as is.

Thanks again,
Stephan

@hyacinthus
Copy link

So seven months have gone...

@StephanDollberg
Copy link
Owner

StephanDollberg commented Feb 16, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants