fix(frontend): support Windows shell commands in Claude CLI invocation (ACS-261) #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n (ACS-261) Fixes hang on Windows after "Environment override check" log by replacing hardcoded bash commands with platform-aware shell syntax. - Windows: Uses cmd.exe syntax (cls, call, set, del) with .bat temp files - Unix/macOS: Preserves existing bash syntax (clear, source, export, rm) - Adds error handling and 10s timeout protection in async invocation - Extracts helper functions for DRY: generateTokenTempFileContent(), getTempFileExtension() - Adds 7 Windows-specific tests (30 total tests passing)
github-actions
bot
added
area/frontend
bug
Owner
Author
|
Superseded by upstream PR: AndyMik90#1152 |
StillKnotKnown
pushed a commit
that referenced
this pull request
Jan 18, 2026
…ik90#1259) * fix(windows): prevent zombie process accumulation on app close - Use taskkill /f /t on Windows to properly kill process trees (SIGTERM/SIGKILL are ignored on Windows) - Make killAllProcesses() wait for process exit events with timeout - Kill PTY daemon process on shutdown - Clear periodic update check interval on app quit Fixes process accumulation in Task Manager after closing Auto-Claude. Co-Authored-By: Claude Opus 4.5 <[email protected]> * fix(windows): extract killProcessGracefully utility with timer cleanup - Extract shared killProcessGracefully() to platform module - Fix Issue #1: Move taskkill outside try-catch scope - Fix Issue #2: Track exit state to skip unnecessary taskkill - Fix Issue #3: Add GRACEFUL_KILL_TIMEOUT_MS constant - Fix Issue #4: Use consistent 5000ms timeout everywhere - Fix Issue #5: Add debug logging for catch blocks - Fix Issue AndyMik90#6: Log warning when process.once unavailable - Fix Issue AndyMik90#7: Eliminate code duplication across 3 files - Fix timer leak: Clear timeout on process exit/error, unref timer Add comprehensive tests (19 test cases) covering: - Windows taskkill fallback behavior - Unix SIGTERM/SIGKILL sequence - Timer cleanup and memory leak prevention - Edge cases and error handling Co-Authored-By: Claude Opus 4.5 <[email protected]> --------- Co-authored-by: Claude Opus 4.5 <[email protected]> Co-authored-by: Andy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes hang on Windows after "Environment override check" log by replacing hardcoded bash commands with platform-aware shell syntax.
Problem
On Windows, the terminal would hang indefinitely after logging "Environment override check" because
buildClaudeShellCommand()was hardcoded to usebash -ccommands that don't exist on Windows.Solution
Windows: Uses cmd.exe/PowerShell compatible syntax:
clsinstead ofclearcallto execute .bat temp filessetfor environment variablesdelfor file cleanup.batextension for temp files with\r\nline endingsUnix/macOS: Preserves existing bash syntax (unchanged):
clear,source,export,rm -f\nline endingsChanges
buildClaudeShellCommand()to detect platform and generate appropriate commandsgenerateTokenTempFileContent()helper for DRYgetTempFileExtension()helper for DRYinvokeClaudeAsync()Test Plan
claude-integration-handler.test.tspassingpath.join(),os.tmpdir())Linear Ticket
Resolves ACS-261