feat: StreamRow skeleton first paint (Issue #1033) - #1338
Merged
greatest0fallt1me merged 4 commits intoJul 29, 2026
Conversation
JS hook + data-reduced-motion attribute + swipe-transition guard. CSS-level prefers-reduced-motion fallback in globals.css. Focused tests for all statuses.
Adds a loading prop to StreamRow that renders a themed skeleton placeholder matching the StreamRow layout — identity avatar, recipient name, schedule, status badge, meta section (Rate/Status/Burn-down), progress bar, and action button. Uses the existing Skeleton component with proper aria-busy and aria-hidden for accessibility.
|
@VeronicDev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Merged into main via admin resolver (-X theirs). |
Contributor
|
LGTM — clean, tested. Merged 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a loading skeleton placeholder that renders while StreamRow data is loading, preventing blank flash on first paint (Issue #1033).
Changes
app/components/StreamRow.tsx
loading?: booleanprop toStreamRowPropswith JSDoc documentationloading=true(before any hooks, matching StreamProgress pattern)aria-busy="true"andaria-label="Stream row is loading"aria-hidden="true"stream-row--compactclass whendensity="compact"Skeletoncomponent from./Skeletonapp/components/StreamRow.test.tsx
loading skeleton (Issue #1033)describe block:stream-row--skeletonclassaria-busy="true"attributearia-label="Stream row is loading"aria-hidden="true"Testing
StreamProgressskeleton implementationCloses #1033